Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing verbosityLMTranslator case #716

Merged
merged 2 commits into from
Mar 19, 2021
Merged

fix missing verbosityLMTranslator case #716

merged 2 commits into from
Mar 19, 2021

Conversation

jlblancoc
Copy link
Member

LevenbergMarquardtParams::verbosityLMTranslator() was missing one of the possible enum values.

@jlblancoc jlblancoc added bugfix Fixes an issue or bug easy-fix Quick and easy to fix labels Mar 17, 2021
varunagrawal
varunagrawal approved these changes Mar 17, 2021
View reviewed changes
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though you may have to merge develop once we fix #717

@jlblancoc
Copy link
Member Author

Thanks for merging develop!

@jlblancoc jlblancoc merged commit 74e4fc3 into develop Mar 19, 2021
@jlblancoc jlblancoc deleted the fix-verbosityLMTranslator branch March 19, 2021 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varunagrawal varunagrawal varunagrawal approved these changes

Assignees
No one assigned
Labels
bugfix Fixes an issue or bug easy-fix Quick and easy to fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlblancoc @varunagrawal