Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LieGroups.lyx #693

Merged
merged 2 commits into from
Feb 7, 2021
Merged

Update LieGroups.lyx #693

merged 2 commits into from
Feb 7, 2021

Conversation

melhashash
Copy link
Contributor

Fix typo in the equation in item 1 section 5.3

Fix typo in the equation in item 1 section 5.3
Copy link
Contributor

@mikesheffler mikesheffler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this is correct. I don't think the corresponding .pdf is automatically generated (note that it is present in the source tree), so I don't want to approve it yet.

Should @melhashash generate a .pdf, or does someone in particular create it?

@dellaert
Copy link
Member

dellaert commented Feb 7, 2021

I think this is right. I'll approve but if you can render the PDF that would be better. I'll wait to merge until I heard from you.

pdf is generated after fixing a typo in the equation in item number 1, section 5.3.
@melhashash
Copy link
Contributor Author

I have generated the pdf.

Note: the font has changed, and references are added at the end (it was missing in the original document).

@dellaert @mikesheffler

@dellaert
Copy link
Member

dellaert commented Feb 7, 2021

Awesome, thanks !

@dellaert dellaert merged commit d304358 into borglab:develop Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants