Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CMake Variables and TBB build type #683

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Update CMake Variables and TBB build type #683

merged 2 commits into from
Jan 29, 2021

Conversation

varunagrawal
Copy link
Collaborator

  1. Update non-user-editable CMake variables to be INTERNAL.
  2. TBB should be in Release mode by default unless TBB_USE_DEBUG_BUILD=ON is specified. This fixes Building with TBB on macOS for "debug" build types #661.

@varunagrawal varunagrawal added the bugfix Fixes an issue or bug label Jan 22, 2021
@varunagrawal varunagrawal self-assigned this Jan 22, 2021
@dellaert dellaert removed their request for review January 22, 2021 19:37
@dellaert
Copy link
Member

I'm ok if @jlblancoc is ok :-)

jlblancoc
jlblancoc approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@jlblancoc jlblancoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jlblancoc jlblancoc merged commit b92a942 into develop Jan 29, 2021
@dellaert dellaert deleted the fix/cmake-variables branch December 29, 2021 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlblancoc jlblancoc jlblancoc approved these changes

Assignees

@varunagrawal varunagrawal

Labels
bugfix Fixes an issue or bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building with TBB on macOS for "debug" build types
3 participants
@varunagrawal @dellaert @jlblancoc