Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Known Issues Section #681

Merged
merged 3 commits into from
Jan 28, 2021
Merged

Known Issues Section #681

merged 3 commits into from
Jan 28, 2021

Conversation

varunagrawal
Copy link
Collaborator

@varunagrawal varunagrawal commented Jan 20, 2021

Added a new section in INSTALL.md for known issues which discusses conditions for the issue in #590.

@chrisbeall
Copy link
Member

I tried on Ubuntu 16.04 with Boost 1.68, compiled locally with gcc 5.4 (not from PPA), and the problem persists. It appears that the compiler matters, too.

I think it's better to document this issue in the readme or install notes under "Known Issues" than to force users to upgrade Boost because Ubuntu 16.04 with Boost 1.58 is still widely used. A CMake warning might be ok, too.

@varunagrawal
Copy link
Collaborator Author

@chrisbeall interesting. What would be the minimum supported compiler for GCC? We use GCC 5.5.0 in the CI and but turn off march_native.

@varunagrawal varunagrawal changed the title Minimum Boost version to 1.67 Known Issues Section Jan 20, 2021
Copy link
Member

@jlblancoc jlblancoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal, but this is probably a good deal: reporting the known issues which we have not been able to fix or would require users to upgrade to fix a bug in a part (serialization) that they may not need at all for their projects.

I defer the PR approval to Frank or other core developers, since this is more a "policy" than a technical discussion.

@varunagrawal
Copy link
Collaborator Author

@jlblancoc I updated the PR to only have the known issues section. Does it look good to you?

@varunagrawal varunagrawal added the docs Update to docs or README without code changes label Jan 22, 2021
@dellaert dellaert merged commit ca44312 into develop Jan 28, 2021
@dellaert dellaert deleted the fix/boost-version-update branch December 29, 2021 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes an issue or bug docs Update to docs or README without code changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants