Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/warnings #656

Merged
merged 2 commits into from
Jan 5, 2021
Merged

Fix/warnings #656

merged 2 commits into from
Jan 5, 2021

Conversation

dellaert
Copy link
Member

@dellaert dellaert commented Jan 5, 2021

Fixed warnings I found when compiling with latest clang.
This includes forgotten virtual destructor in Cal3.

varunagrawal
varunagrawal reviewed Jan 5, 2021
View reviewed changes
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Any reason we're switching from const references in the for-ranges to const values?

@dellaert
Copy link
Member Author

dellaert commented Jan 5, 2021

Cool! Any reason we're switching from const references in the for-ranges to const values?

The boost-created range functionality does not yield references. That's what the warning was.

@dellaert
Copy link
Member Author

dellaert commented Jan 5, 2021

@varunagrawal when you approve, feel free to immediately merge.

varunagrawal
varunagrawal approved these changes Jan 5, 2021
View reviewed changes
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varunagrawal varunagrawal merged commit c57b115 into develop Jan 5, 2021
@varunagrawal varunagrawal deleted the fix/warnings branch January 5, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varunagrawal varunagrawal varunagrawal approved these changes

Assignees

@dellaert dellaert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dellaert @varunagrawal