Wrapping prior factor and general sfm factor or Cal3Bundler #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushbaid
added
easy-fix
varunagrawal
requested changes
Dec 28, 2020
gtsam/gtsam.i
Outdated
| @@ -2666,14 +2666,17 @@ typedef gtsam::GeneralSFMFactor<gtsam::PinholeCameraCal3_S2, gtsam::Point3> Gene | |||
| typedef gtsam::GeneralSFMFactor<gtsam::PinholeCameraCal3DS2, gtsam::Point3> GeneralSFMFactorCal3DS2; | |||
| typedef gtsam::GeneralSFMFactor<gtsam::PinholeCamera<gtsam::Cal3Bundler>, gtsam::Point3> GeneralSFMFactorCal3Bundler; | |||
|
|
|||
| template<CALIBRATION = {gtsam::Cal3_S2}> | |||
| template<CALIBRATION> | |||
There was a problem hiding this comment.
Since this is a single template parameter, you can just list out the template arguments and get rid of the typedefs, like this:
template<CALIBRATION = {gtsam::Cal3_S2, gtsam::Cal3DS2, gtsam::Cal3Bundler}>There was a problem hiding this comment.
This works! Thanks!
dellaert
approved these changes
Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The python API has support for
PriorFactorandGeneralSFMFactor2for calibration classCal3_S2, but not forCal3Bundler.In this PR, we add the same wraps for
Cal3Bundlercalibration class.