Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly initialize Point3 #635

Merged
merged 2 commits into from
Dec 10, 2020
Merged

Explicitly initialize Point3 #635

merged 2 commits into from
Dec 10, 2020

Conversation

varunagrawal
Copy link
Collaborator

Fixes a warning in the tests. Was super easy so decided to go ahead and take care of it.

@varunagrawal varunagrawal added quick-review Quick and easy PR to review easy-fix Quick and easy to fix labels Dec 10, 2020
@varunagrawal varunagrawal self-assigned this Dec 10, 2020
g.add(BetweenFactor<Pose3>(x2, x0, Pose3(Rot3::Ypr(0.1,0,0.1), Point3()), noiseModel::Isotropic::Precision(6, 0.0))); // random pose, but zero information
g.add(BetweenFactor<Pose3>(x0, x3, Pose3(Rot3::Ypr(0.5,-0.2,0.2), Point3(10,20,30)), noiseModel::Isotropic::Precision(6, 0.0))); // random pose, but zero informatoin
// random pose, but zero information
g.add(BetweenFactor<Pose3>(x2, x0,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did format and that is what I got.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. This is very strange...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a refactor so that the formatting is more consistent.

Copy link
Collaborator

@ProfFan ProfFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@varunagrawal varunagrawal merged commit 6c85850 into develop Dec 10, 2020
@varunagrawal varunagrawal deleted the fix/warning branch December 10, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy-fix Quick and easy to fix quick-review Quick and easy PR to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants