Miscellaneous fixes #616
Merged
Miscellaneous fixes #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
varunagrawal
commented
Nov 28, 2020
varunagrawal
commented
- Suppress warnings for clang as well as gcc.
- Fix warning for potentially unassigned pointer.
- Plotting code fixes.
varunagrawal
added
bugfix
dellaert
reviewed
Nov 28, 2020
| @@ -199,7 +199,7 @@ if(WIN32) | |||
| else() | |||
| if("${CMAKE_BUILD_TYPE}" STREQUAL "Release") | |||
| # Suppress all warnings from 3rd party sources. | |||
| set_source_files_properties(${3rdparty_srcs} PROPERTIES COMPILE_FLAGS "-w") | |||
| set_source_files_properties(${3rdparty_srcs} PROPERTIES COMPILE_FLAGS "-w -Wno-everything") | |||
There was a problem hiding this comment.
That's the flag to suppress warnings in Clang. -w already does so for GCC, but Clang still throws warnings in Release mode.
| @@ -36,18 +36,15 @@ def set_axes_equal(fignum): | |||
| ax.set_zlim3d([origin[2] - radius, origin[2] + radius]) | |||
|
|
|||
|
|
|||
| def ellipsoid(xc, yc, zc, rx, ry, rz, n): | |||
| def ellipsoid(rx, ry, rz, n): | |||
There was a problem hiding this comment.
The center point values are not used in the function anywhere. They are simply wasteful args that serve no purpose.
dellaert
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.