-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark Values::at return type as const #608
Conversation
In principle... it LGTM. However, if you don't mind, please wait until I add a minimal unit test failing before, passing after, ok? I would push directly here to your branch, ok? |
Sounds great! |
This fixes my original problem, thanks! But before merging, please check out the additional point I'm adding to #606. |
(just a reminder) this pr is waiting for a design decision by @dellaert in #606 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large diff because of formatting changes. Could you undo all formatting changes and just leave the changes for this PR? Also messes up "blame".
This reverts commit 5749565.
@dellaert all done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Fixes #606