Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce constant term in QP to be default 0 #607

Merged
merged 1 commit into from
Nov 19, 2020
Merged

Enforce constant term in QP to be default 0 #607

merged 1 commit into from
Nov 19, 2020

Conversation

varunagrawal
Copy link
Collaborator

Fixes #306.

I also added braces for the if statements because that is good style.

@varunagrawal varunagrawal added bugfix Fixes an issue or bug quick-review Quick and easy PR to review high-priority Need this done quickly easy-fix Quick and easy to fix labels Nov 19, 2020
@varunagrawal varunagrawal self-assigned this Nov 19, 2020
@varunagrawal varunagrawal mentioned this pull request Nov 19, 2020
Closed
@varunagrawal varunagrawal changed the title Enforce constant term in QP to be 0 Enforce constant term in QP to be default 0 Nov 19, 2020
@varunagrawal varunagrawal merged commit ea2064e into develop Nov 19, 2020
@varunagrawal varunagrawal deleted the fix/306 branch November 19, 2020 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dellaert dellaert dellaert approved these changes

@ProfFan ProfFan Awaiting requested review from ProfFan

@jlblancoc jlblancoc Awaiting requested review from jlblancoc

@gchenfc gchenfc Awaiting requested review from gchenfc

Assignees

@varunagrawal varunagrawal

Labels
bugfix Fixes an issue or bug easy-fix Quick and easy to fix high-priority Need this done quickly quick-review Quick and easy PR to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed test on 32bit architectures
2 participants
@varunagrawal @dellaert