-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish GTSAM artifacts #602
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
2 comments:
- is there a reason not to do this for python and special cases?
- The artifacts are pretty big since they are uploading the entire build directory, especially the debug zip which is ~10GB. This has the dual byproducts of extra CI time (~15min for debug to upload the file) and a pretty time to download the artifacts down from github. Neither of these are deal breakers for me, but just thought I'd point out how large the files are. Perhaps an argument could be made for a more selective approach?
@gchenfc Python wheels need very special build environments (check gtsam-manylinux-build) to make them run on every possible Linux distro you have. That is also very expensive (currently needs a custom GitHub runner hosted on GCE). Also I second Gerry's 2nd point here - I think GitHub has a 10G-ish quota on storage space? |
I am not sure about the file size limit because Actions is not complaining about it, but you are right, if the upload is adding to the overall time, it doesn't make sense to add all the files. I wonder if zipping up the build directory would make a difference? |
github billing Hmm. Maybe not using debug builds and also only uploading builds on merge with develop? |
No worries here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, didn't read carefully that the limits/billing only applied to private repos.
Personally I would prefer only enabling this on release builds just to speed up builds, but up to you!
I completely agree with you on the Release part. For downstream use, Debug builds for the CI just seem like an unnecessary time sink. |
Also, "free for public repos" is one of the reasons why I convinced Frank to move from Bitbucket to Github. We have so much tooling available to make life easy now. |
Okay wow, release builds are less than 500 MB while debug builds are > 4 GB!!! Great recommendation @gchenfc. |
Updated the Actions workflow to upload the corresponding build directories, so we can use the latest version of GTSAM in CI pipelines for other repos (e.g. GTDynamics).