Consistent interface for pixel center #579
Conversation
varunagrawal
added
bugfix
Yes, please :-) |
Wouldn't it be advisable to remove the px and py in the other models and reflect those changes across all places that use it, then? Might cause some avoidable confusion otherwise. |
| @@ -597,6 +597,7 @@ class Rot3 { | |||
| Rot3(double R11, double R12, double R13, | |||
| double R21, double R22, double R23, | |||
| double R31, double R32, double R33); | |||
| Rot3(double w, double x, double y, double z); | |||
There was a problem hiding this comment.
Is this related to this PR? (I'm assuming it's a quaternion rot constructor?)
There was a problem hiding this comment.
It isn't, but it was minor and I didn't want to create a whole new PR for it.
That would break backwards compatibility. Also a lot of internal code uses the |
|
Please request a re-review after adding px and py to missing Cal. Remove all u0 and v0 that were not there yet. Pls deprecate u0 and v0 if there was any. |
gtsam/geometry/Cal3Bundler.h
Outdated
| return v0_; | ||
| } | ||
|
|
||
| /// @deprecated |
There was a problem hiding this comment.
No, we have this #ifdef thingy, remember ? :-)
There was a problem hiding this comment.
Uhhh I'm stupid
| class SfmTrack { | ||
| SfmTrack(); | ||
|
|
||
| double r; |
There was a problem hiding this comment.
The wrap parser doesn't support this syntax. :(
gtsam/gtsam.i
Outdated
| double r; | ||
| double g; | ||
| double b; | ||
| //TODO Need to close wrap#10 to allow this to work. |
There was a problem hiding this comment.
Please use Google-style linting, which should flag an issue here.
|
Will squash and merge once CI passes. |
Defined u0 and v0 in all camera models for consistent interface.