Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LP/QP Style Update #546

Merged
merged 6 commits into from
Oct 2, 2020
Merged

LP/QP Style Update #546

merged 6 commits into from
Oct 2, 2020

Conversation

dellaert
Copy link
Member

Starting to clean up LP/QP in anticipation of using it more.

@dellaert dellaert changed the title Fix/lp qp stype LP/QP Style Update Oct 2, 2020
@dellaert
Copy link
Member Author

dellaert commented Oct 2, 2020

@gchenfc pls review :-)

Copy link
Member

@gchenfc gchenfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See include order of unit test files, and my question about return by copy elision. Otherwise looks good!

gtsam_unstable/linear/tests/testLPSolver.cpp Outdated Show resolved Hide resolved
gtsam_unstable/linear/tests/testQPSolver.cpp Outdated Show resolved Hide resolved
gtsam_unstable/linear/ActiveSetSolver-inl.h Show resolved Hide resolved
@dellaert dellaert merged commit 188efad into develop Oct 2, 2020
@dellaert dellaert deleted the fix/LP_QP_stype branch October 2, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants