Automatically find Python3 version #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://cmake.org/cmake/help/latest/module/FindPython.html : |
|
I wanted to fail if Python3 is not found, rather than fall back to Python2. I strongly believe we should not support Python2 on our end. |
ProfFan
approved these changes
Sep 21, 2020
|
I have the same questions # |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use CMake to identify best Python3 version if
Defaultrequested.Note that the CMake code looks specifically for Python3 as we shouldn't be supporting the EOL'd Python2.
This also helps get rid of a bunch of checks for the
Defaultvalue.Fixes #519 and #522.