Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap the DSFMap class so SFM can use them #511

Merged
merged 3 commits into from
Sep 7, 2020
Merged

Wrap the DSFMap class so SFM can use them #511

merged 3 commits into from
Sep 7, 2020

Conversation

ProfFan
Copy link
Collaborator

@ProfFan ProfFan commented Sep 6, 2020

Note: this contains a workaround on the template specialization limit of the wrapper.

@ProfFan
Copy link
Collaborator Author

ProfFan commented Sep 7, 2020

@dellaert @varunagrawal

varunagrawal
varunagrawal approved these changes Sep 7, 2020
View reviewed changes
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally looks great!
Some design/style recommendations though.

gtsam/base/DSFMap.h Show resolved Hide resolved
gtsam/gtsam.i Show resolved Hide resolved
@ProfFan ProfFan merged commit bf7213f into develop Sep 7, 2020
@ProfFan ProfFan deleted the feature/wrap_dsf branch September 7, 2020 17:50
@ProfFan
Copy link
Collaborator Author

ProfFan commented Sep 7, 2020

@swarrier246 Now you can switch back to develop :)

@swarrier246
Copy link
Contributor

Thanks, @ProfFan ! Appreciate the help

@ProfFan ProfFan mentioned this pull request Sep 8, 2020
Merged
@ProfFan ProfFan mentioned this pull request Sep 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varunagrawal varunagrawal varunagrawal approved these changes

@dellaert dellaert Awaiting requested review from dellaert

@swarrier246 swarrier246 Awaiting requested review from swarrier246

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ProfFan @swarrier246 @varunagrawal