Include 3rdparty libraries as 'system' headers to avoid warnings #478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one enables warnings-as-errors (e.g. "suggest override") the compiler reports warnings/errors in 3rdparty code, e.g.
In general, it's "safer" to include 3rdparty and system libraries as... "system libraries" in CMake's terminology :-)
Goal: Enabling stricter levels of warnings/errors in gtsam code itself, while not failing to build due to non-compliant external dependencies.