attempt to replace deprecated tbb functionality #336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
I might take this up since I would like to use TBB more (as well as figure out the benchmarking issues that @chrisbeall mentioned a while ago). Here's a nice discussion about alternatives: oneapi-src/oneTBB#243 |
|
@varunagrawal please feel free to, would really appreciate it. Also I already linked that issue in this PR's corresponding issue thread. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to resolve #208
I was able to replace the creation of the old api
taskswith functors being passed intotask_groups. This does compile, however, many unit tests fail.Since I don't really have much time to continue working on this, I may not come back to this. But I did want to open up my attempt so that others so inclined can gather some insight from this PR and continue working off of it.
This is not really that important for most people since the issue only effects TBB 2020.2 as a warning, (and will prob be an error in the next TBB release) while Ubuntu LTS is on an older TBB (and will be until the next LTS 2 years from now)
This change is