Release tag free wrapper #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we close after our off-line discussion? |
|
Yes let's close this.
For future context, we've decided to modify the actual cython wrapper to
link to the correct version of the .so files based on the postfix. This
will prevent confusion when making updates to the cython wrapper in the
future.
…On Wed, May 29, 2019, 23:19 Frank Dellaert ***@***.***> wrote:
Should we close after our off-line discussion?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#26?email_source=notifications&email_token=AAHOIXCJA3V4J375WAE6EJDPX5BUDA5CNFSM4HQIPSXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWRHRUA#issuecomment-497187024>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAHOIXFDEPA4YG55Q3RR46LPX5BUDANCNFSM4HQIPSXA>
.
|
|
Ok |
varunagrawal
added a commit
that referenced
this pull request
Jan 13, 2021
186ed2c79 Merge pull request #26 from borglab/fix/required 9af1b8f09 unmake python cmake package as required git-subtree-dir: wrap git-subtree-split: 186ed2c792f80bbd315e747ef8622f8355c626f6
varunagrawal
added a commit
that referenced
this pull request
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the cmake files so that the non-release versions of the
gtsam.soand other similar files do not have the release type tag attached to them. This also ensures the release specific information (e.g.debuginfo) is properly captured rather than circumvented.