Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore stubgen errors and wrap TriangulationFactor #1846

Merged
merged 9 commits into from
Sep 26, 2024

Conversation

varunagrawal
Copy link
Collaborator

@varunagrawal varunagrawal commented Sep 25, 2024

Until #1824 is addressed, I suggest we keep using mypy's stubgen.
I've kept the #include<algorithm> for compilation.

Additionally, fixes #1758.

Updated to also address #1791.

@varunagrawal varunagrawal self-assigned this Sep 25, 2024
@varunagrawal varunagrawal linked an issue Sep 25, 2024 that may be closed by this pull request
@ProfFan
Copy link
Collaborator

ProfFan commented Sep 26, 2024

I think it does not matter? Mypy has the same issue, they just pretend that it does not exist, the generated signature is Any, which pybind11-stubgen also do anyways. #1824 is universal to any generator.

@varunagrawal
Copy link
Collaborator Author

I think it does not matter? Mypy has the same issue, they just pretend that it does not exist, the generated signature is Any, which pybind11-stubgen also do anyways. #1824 is universal to any generator.

Yes but at least we don't get bombarded by a bunch of error messages. Those error messages are very misleading and for someone not familiar with the wrapper and stub generation, it can be very confusing.

@ProfFan
Copy link
Collaborator

ProfFan commented Sep 26, 2024

I think it does not matter? Mypy has the same issue, they just pretend that it does not exist, the generated signature is Any, which pybind11-stubgen also do anyways. #1824 is universal to any generator.

Yes but at least we don't get bombarded by a bunch of error messages. Those error messages are very misleading and for someone not familiar with the wrapper and stub generation, it can be very confusing.

I see, if that's the use case the only change needed is --ignore-all-errors in the command line

@varunagrawal varunagrawal changed the title Revert to mypy stubgen and wrap TriangulationFactor Ignore stubgen errors and wrap TriangulationFactor Sep 26, 2024
Copy link
Collaborator

@ProfFan ProfFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@varunagrawal varunagrawal merged commit d72d23c into develop Sep 26, 2024
33 checks passed
@varunagrawal varunagrawal deleted the wrap-triangulation-factor branch September 26, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boostless GTSAM built requires Boost as dependency TriangulationFactor Python
2 participants