Skip to content

add useLOST to triangulateSafe#1517

Merged
dellaert merged 1 commit into
borglab:developfrom
dllu:develop
Sep 4, 2023
Merged

add useLOST to triangulateSafe#1517
dellaert merged 1 commit into
borglab:developfrom
dllu:develop

Conversation

@dllu
Copy link
Copy Markdown
Contributor

@dllu dllu commented Apr 19, 2023

adds a way to use the new LOST triangulation in triangulateSafe by setting the useLOST parameter in TriangulationParameters accordingly.

By the way, what version of clang-format do people use? for some reason when I ran clang-format -i gtsam/geometry/triangulation.h it resulted in many changed lines (using clang-format version 10.0.0-4ubuntu1).

@zubingtan
Copy link
Copy Markdown
Contributor

If I understand correctly and as discussed in #1503, we should only format the section you modify. If you are using VScode, you can select the section and click the right menu button and use Format Section. cc @dellaert

@akshay-krishnan
Copy link
Copy Markdown
Contributor

Thanks @dllu , it would be great if you could also add a unit test for triangulateSafe with useLOST=True here:

TEST(triangulation, outliersAndFarLandmarks) {

@varunagrawal
Copy link
Copy Markdown
Contributor

@dllu gentle reminder

Copy link
Copy Markdown
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just going to approve and merge.

@dellaert dellaert merged commit 52ecb09 into borglab:develop Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants