Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of boost::assign #1375

Merged
merged 38 commits into from
Jan 10, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
2fe4c83
Make base class constructors available (including initializer lists).
dellaert Jan 7, 2023
c4fb764
Removed boost headers in DecisionTree-inl.h that are no longer needed.
dellaert Jan 7, 2023
d2f0cf5
Inherit constructors for CameraSets to switch to initializer lists.
dellaert Jan 7, 2023
017cd8f
Got rid of boost::assign in many tests
dellaert Jan 7, 2023
313ab01
Got rid of Boost cref_list_of
dellaert Jan 7, 2023
8013779
Removed unused headers
dellaert Jan 7, 2023
d3380bc
Convert to initializer lists
dellaert Jan 7, 2023
f9ccf11
Rid gtsam/linear of boost::assign (a Herculean task made easier with …
dellaert Jan 8, 2023
6cbd7c2
Add initializer list constructors
dellaert Jan 8, 2023
8527b39
Removed copy/pasted but unused boost::assign headers.
dellaert Jan 8, 2023
7e4b033
Using initializers for almost everything in gtsam now.
dellaert Jan 8, 2023
4e078e4
Heavy lift on removing boost::assign from symbolic tests.
dellaert Jan 8, 2023
9b5321c
Remove unused boost::assign headers
dellaert Jan 8, 2023
d3a40fb
Use initializer lists in tests and gtsam_unstable
dellaert Jan 8, 2023
9675761
Merge branch 'develop' into feature/Ordering_initializers
dellaert Jan 8, 2023
276394d
Moved ListOf helper and MakeKeys to common header.
dellaert Jan 8, 2023
edec6f3
Renamed MakeKeys to Keys and cleaned up tests.
dellaert Jan 8, 2023
5164d6f
Cleaned up etree tests
dellaert Jan 8, 2023
ddf86d8
Fix compilation issue on Linux
dellaert Jan 8, 2023
638726f
An attempt to fix Windows issue.
dellaert Jan 8, 2023
73754f2
Fix typo
dellaert Jan 8, 2023
15802e5
Address review comments
dellaert Jan 9, 2023
fa3a810
Fix issues with gcc compiler.
dellaert Jan 9, 2023
1e99f68
Renamed ListOf to something more descriptive
dellaert Jan 9, 2023
9a6b0dd
Add FactorGraph-inst.h
dellaert Jan 9, 2023
c486472
Attempts at fixing CI gcc/windows
dellaert Jan 9, 2023
36d6b70
Fix gcc compilation errors by using correct allocator.
dellaert Jan 10, 2023
3b369e5
Define Errors as a typedef to FastList<Vector>.
dellaert Jan 10, 2023
a9409ac
Kill errors wrapper - internal class not used in any tests.
dellaert Jan 10, 2023
98f3c96
Replace blanket inclusion of constructors (giving trouble on Windows)…
dellaert Jan 10, 2023
b51f176
Simplify initializer list constructors.
dellaert Jan 10, 2023
0e01ea6
Fix issue with initializer constructors
dellaert Jan 10, 2023
353a5b3
Forgot to add correct type in elimination tree (needed for compilatio…
dellaert Jan 10, 2023
874f0de
One last omission
dellaert Jan 10, 2023
6a035b8
Two more tbb compile issues
dellaert Jan 10, 2023
416cb65
Remove const, use size_t everywhere.
dellaert Jan 10, 2023
61ff43f
Yet another issue with gcc-tbb
dellaert Jan 10, 2023
d41d4c2
Another gcc issue, switch to FastList
dellaert Jan 10, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Heavy lift on removing boost::assign from symbolic tests.
  • Loading branch information
dellaert committed Jan 8, 2023
commit 4e078e41f18cad5256c40c7bee083e18d184b363
16 changes: 16 additions & 0 deletions gtsam/symbolic/SymbolicBayesNet.h
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,22 @@ namespace gtsam {
for (auto&& f : sharedFactors) factors_.push_back(f);
}

/// Construct from a single conditional
SymbolicBayesNet(SymbolicConditional&& c) {
push_back(boost::make_shared<SymbolicConditional>(c));
}

/**
* @brief Add a single conditional and return a reference.
* This allows for chaining, e.g.,
* SymbolicBayesNet bn =
* SymbolicBayesNet(SymbolicConditional(...))(SymbolicConditional(...));
*/
SymbolicBayesNet& operator()(SymbolicConditional&& c) {
push_back(boost::make_shared<SymbolicConditional>(c));
dellaert marked this conversation as resolved.
Show resolved Hide resolved
return *this;
}

/// Destructor
virtual ~SymbolicBayesNet() {}

Expand Down
16 changes: 16 additions & 0 deletions gtsam/symbolic/SymbolicFactorGraph.h
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,22 @@ namespace gtsam {
for (auto&& f : sharedFactors) factors_.push_back(f);
}

/// Construct from a single factor
SymbolicFactorGraph(SymbolicFactor&& c) {
push_back(boost::make_shared<SymbolicFactor>(c));
}

/**
* @brief Add a single factor and return a reference.
* This allows for chaining, e.g.,
* SymbolicFactorGraph bn =
* SymbolicFactorGraph(SymbolicFactor(...))(SymbolicFactor(...));
*/
SymbolicFactorGraph& operator()(SymbolicFactor&& c) {
dellaert marked this conversation as resolved.
Show resolved Hide resolved
push_back(boost::make_shared<SymbolicFactor>(c));
return *this;
}

/// Destructor
virtual ~SymbolicFactorGraph() {}

Expand Down
Loading