Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Big Re-"Factor" of Hybrid #1374

Merged
merged 16 commits into from
Jan 8, 2023
Merged

Big Re-"Factor" of Hybrid #1374

merged 16 commits into from
Jan 8, 2023

Commits on Jan 6, 2023

  1. Document methods, refactor pruning a tiny bit.

    @dellaert
    dellaert committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    408c14b View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2023

  1. Fix (very old) Factor documentation

    @dellaert
    dellaert committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    ce27a8b View commit details
    Browse the repository at this point in the history

  2. Make HybridFactorGraph just a FactorGraph<Factor> with extra methods

    @dellaert
    dellaert committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    1538452 View commit details
    Browse the repository at this point in the history

  3. Remove HybridNonlinearFactor wrapper class as no longer needed

    @dellaert
    dellaert committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    88129d9 View commit details
    Browse the repository at this point in the history

  4. Moved key methods to cpp file

    @dellaert
    dellaert committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    b93de21 View commit details
    Browse the repository at this point in the history

  5. Removed HybridDiscreteFactor wrapper

    @dellaert
    dellaert committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    7e32a87 View commit details
    Browse the repository at this point in the history

  6. Made tests compile after purging HybridDiscreteFactor

    @dellaert
    dellaert committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    18d4bdf View commit details
    Browse the repository at this point in the history

  7. Use template specialization

    @dellaert
    dellaert committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    876e2e8 View commit details
    Browse the repository at this point in the history

  8. Fixed tests

    @dellaert
    dellaert committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    88f27a2 View commit details
    Browse the repository at this point in the history

  9. Added handling of naked Gaussian factors added in python

    @dellaert
    dellaert committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    a46c53d View commit details
    Browse the repository at this point in the history

  10. Fix python test to not use add

    @dellaert
    dellaert committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    8d96b3e View commit details
    Browse the repository at this point in the history

  11. Remove GaussianFactor wrapper (easy!)

    @dellaert
    dellaert committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    4e8dc6e View commit details
    Browse the repository at this point in the history

  12. Add all discrete keys

    @dellaert
    dellaert committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    84037e1 View commit details
    Browse the repository at this point in the history

  13. Removed emplace_hybrid, can be done with emplace_shared now...

    @dellaert
    dellaert committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    e6fe909 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2023

  1. Merge branch 'develop' into hybrid/refactor 

    # Conflicts:
#	gtsam/hybrid/HybridGaussianFactorGraph.cpp
#	gtsam/hybrid/tests/testHybridGaussianFactorGraph.cpp
#	python/gtsam/tests/test_HybridNonlinearFactorGraph.py
    @dellaert
    dellaert committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    2e23336 View commit details
    Browse the repository at this point in the history

  2. Fix issue with HybridOrdering

    @dellaert
    dellaert committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    691baa5 View commit details
    Browse the repository at this point in the history