Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Un-deprecate NoiseModelFactor1-6 and move X1 and key1-6 shortcuts to NoiseModelFactorN #1370

Merged
merged 4 commits into from
Jan 5, 2023
Merged

Un-deprecate NoiseModelFactor1-6 and move X1 and key1-6 shortcuts to NoiseModelFactorN #1370

merged 4 commits into from
Jan 5, 2023

Commits on Jan 5, 2023

  1. Move X1-6 aliases into NoiseModelFactorN and un-deprecate

    @gchenfc
    gchenfc committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    69226ed View commit details
    Browse the repository at this point in the history

  2. revert confusing ->template key<N>() notations 

    revert to using shortcut form: `key1()`, `key2()`
    @gchenfc
    gchenfc committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    97fcb40 View commit details
    Browse the repository at this point in the history

  3. Revert "revert confusing ->template key<N>() notations" 

    This reverts commit 97fcb40.
    @gchenfc
    gchenfc committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    b46fd77 View commit details
    Browse the repository at this point in the history

  4. Correctly revert confusing ->template key<N>() notations 

    revert to using shortcut form: `key1()`, `key2()`
    @gchenfc
    gchenfc committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    8f2c978 View commit details
    Browse the repository at this point in the history