Fix matlab toolbox compilation #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varunagrawal
added
bugfix
gchenfc
approved these changes
Aug 1, 2022
| @@ -137,7 +137,7 @@ class FitBasis { | |||
| static gtsam::GaussianFactorGraph::shared_ptr LinearGraph( | |||
| const std::map<double, double>& sequence, | |||
| const gtsam::noiseModel::Base* model, size_t N); | |||
| This::Parameters parameters() const; | |||
| gtsam::This::Parameters parameters() const; | |||
There was a problem hiding this comment.
This (no pun intended) doesn't make sense to me - is This a special keyword in the wrapper or something?
Shouldn't this make sense to just be gtsam::FitBasis::Parameters ?
There was a problem hiding this comment.
This is used when we have templated types so that the correct substitution for the template happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interface files for Matlab toolbox were missing some namespaces. This PR adds them so that matlab wrapper compilation works as expected.
Fixes #1246