Added more tests for basis #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dellaert
commented
Feb 27, 2022
dellaert
commented
- moved tests for BasisFactors to basis folder
- added tests for EvaluationFactor and ManifoldEvaluationFactor
- added test for ManifoldEvaluationFunctor in testChebyshev2
varunagrawal
approved these changes
Feb 28, 2022
There was a problem hiding this comment.
LGTM but we should probably add some dedicated tests for FunctorizedFactor (which IMO was one of the key innovations that got this stuff working!).
The BasisFactor tests currently serve more as integration tests rather than unit tests and I see this as my shortcoming in hindsight.
|
I just moved them to the right place and added some more :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.