Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frobenius Factor Eigen Fix #1096

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Frobenius Factor Eigen Fix #1096

merged 1 commit into from
Feb 10, 2022

Conversation

varunagrawal
Copy link
Collaborator

While wrapping hybrid, I encountered intermittent failures of python tests for the FrobeniusBetweenFactor. The fix was simple (specify Eigen alignment) so making a PR for it.

@varunagrawal varunagrawal added the bugfix Fixes an issue or bug label Feb 10, 2022
@varunagrawal varunagrawal self-assigned this Feb 10, 2022
@varunagrawal
Copy link
Collaborator Author

This is the failure I encounter:

Test creation of a Frobenius BetweenFactor. ... python: /home/varun/borglab/gtsam/gtsam/3rdparty/Eigen/Eigen/src/Core/DenseStorage.h:128: Eigen::internal::plain_array<double, 36, 0, 32>::plain_array() [T = double, Size = 36, MatrixOrArrayOptions = 0, Alignment = 32]: Assertion `(internal::UIntPtr(array) & (31)) == 0 && "this assertion is explained here: " "http://eigen.tuxfamily.org/dox-devel/group__TopicUnalignedArrayAssert.html" " **** READ THIS WEB PAGE !!! ****"' failed.
Subprocess aborted

@varunagrawal varunagrawal added the quick-review Quick and easy PR to review label Feb 10, 2022
dellaert
dellaert approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@varunagrawal varunagrawal merged commit a5bee15 into develop Feb 10, 2022
@varunagrawal varunagrawal deleted the fix/FrobeniusFactor branch February 10, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dellaert dellaert dellaert approved these changes

Assignees

@varunagrawal varunagrawal

Labels
bugfix Fixes an issue or bug quick-review Quick and easy PR to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunagrawal @dellaert