New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes to LocalPlaneFactor #1003

Merged

varunagrawal merged 2 commits into develop from fix/change-local-plane-factor-to-shared-noise-model

Jan 3, 2022

Contributor

dwisth commented Jan 3, 2022

Two small changes:

Fix destructor virtual keyword.
Change from SharedGaussian to SharedNoiseModel to support robust cost functions.

dwisth added 2 commits

January 3, 2022 16:05


          fix destructor virtual keyword

6af7c3a


          change from SharedGaussian to SharedNoiseModel

2151fd3

dwisth requested a review from varunagrawal

January 3, 2022 05:11

varunagrawal approved these changes

View reviewed changes

Collaborator

varunagrawal left a comment

LGTM! Thanks for the contribution @dwisth

varunagrawal merged commit a119eb8 into develop

varunagrawal deleted the fix/change-local-plane-factor-to-shared-noise-model branch

January 3, 2022 14:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet