Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DecisionTree Improvements #1002

Merged
merged 4 commits into from
Jan 3, 2022
Merged

DecisionTree Improvements #1002

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a9b2c32
Move DefaultFormatter to base class and add defaults. Also replace Su…
varunagrawal Jan 3, 2022
174490e
kill commented out code
varunagrawal Jan 3, 2022
cfb6011
replace typedef with using and improve docstrings
varunagrawal Jan 3, 2022
022b719
Undo DefaultFormatter change
varunagrawal Jan 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
kill commented out code
  • Loading branch information
@varunagrawal
varunagrawal committed Jan 3, 2022
commit 174490eb510dc39b5cc2b9f2c50764081f99f092
11 changes: 0 additions & 11 deletions gtsam/discrete/tests/testDecisionTree.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,6 @@ struct Crazy {
double b;
};

// bool equals(const Crazy& other, double tol = 1e-12) const {
// return a == other.a && std::abs(b - other.b) < tol;
// }

// bool operator==(const Crazy& other) const {
// return this->equals(other);
// }
// };

struct CrazyDecisionTree : public DecisionTree<string, Crazy> {
/// print to stdout
void print(const std::string& s = "") const {
Expand Down Expand Up @@ -261,8 +252,6 @@ TEST(DT, conversion)
return y != 0;
};
BDT f2(f1, ordering, bool_of_int);
// f1.print("f1");
// f2.print("f2");

// create a value
Assignment<Label> x00, x01, x10, x11;
Expand Down