Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging and Code Coverage #658

Open
3 tasks
varunagrawal opened this issue Jan 5, 2021 · 10 comments
Open
3 tasks

Logging and Code Coverage #658

varunagrawal opened this issue Jan 5, 2021 · 10 comments
Labels
cmake Related to CMake and build system enhancement Improvement to GTSAM feature New proposed feature

Comments

@varunagrawal
Copy link
Collaborator

varunagrawal commented Jan 5, 2021

Feature

Request to add in:

Motivation

Logging will help us print exceptions, warnings and other useful information while at the same time providing a switch which will not impact performance.

Code coverage will ensure we are unit test driven in our development.

Pitch

This feature will require quite a bit of CMake competency, but it should be straightforward enough. Any user should then be able to add various logging statements throughout the codebase (or via a simple include such as <gtsam/base/logging.h>.

The code coverage module will be invoked via a Github Action that will allow us to place a Markdown badge on the README.

Alternatives

Additional context

@varunagrawal varunagrawal added enhancement Improvement to GTSAM feature New proposed feature cmake Related to CMake and build system labels Jan 5, 2021
@jlblancoc
Copy link
Member

Have you considered presenting GTSAM to Google Summer of Code to have extra hands helping in this kind of topics? I could give you a hand as a mentor in case you decide to participate.

@dellaert
Copy link
Member

@jlblancoc I have zero cycles :-) If you want to do this, I fully support it! You are a GTSAM primary by now :-)

@jlblancoc
Copy link
Member

Hmm... I could help you with the registration process, etc. since I've been through it in past years.
However, there is a key page that needs to be ready, by this Friday (Feb 19th): a wiki with the "list of project ideas".
If you, @varunagrawal , and the other developers want to fill this wiki page that I created based on an older one from our project:

https://github.com/borglab/gtsam/wiki/Ideas-page-for-GTSAM-Google-Summer-of-Code-2021

Please, confirm whether we can have by the next Friday:

  • a list of potential mentors.
  • a list of proposed projects,

Best,

@jlblancoc
Copy link
Member

PS: project ideas may be based on some pending issues / PRs, or brand new ideas, etc.

@dellaert
Copy link
Member

OK, let me take a look and give a think. Do you have a list of projects you want to mentor?

@varunagrawal
Copy link
Collaborator Author

I have a bunch of project suggestions. Things like getting the QP solver working, better examples from existing datasets, wrapper features and some old issues that we've basically put on the backburner. I'll update the Wiki page during my lunch break today.

@dellaert
Copy link
Member

It's a bit too late now. Focus on your A->B

@varunagrawal
Copy link
Collaborator Author

Less work for me, plus I made a breakthrough on the URDF issue I was having so the A->B is progressing quickly.

@jlblancoc
Copy link
Member

jlblancoc commented Feb 19, 2021 via email

@varunagrawal
Copy link
Collaborator Author

You're right @jlblancoc. I just saw your comments on this issue today morning, so replied in case this was time sensitive. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Related to CMake and build system enhancement Improvement to GTSAM feature New proposed feature
Projects
None yet
Development

No branches or pull requests

3 participants