Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smartfactor body_P_sensor #20

Closed
dellaert opened this issue May 23, 2019 · 6 comments
Closed

Smartfactor body_P_sensor #20

dellaert opened this issue May 23, 2019 · 6 comments

Comments

@dellaert
Copy link
Member

Not respected: fix it.
@mikesheffler
Copy link
Contributor

What's the deal with this? I see body_P_sensor_ mentioned in the unwhitenedError method in SmartFactorBase.h, but I think that's it. Where is it missed?

@dellaert
Copy link
Member Author

Needs a unit test whether if we pass body_P_sensor, it is actually used in projection factors and the like. It seems it is not, so I expect unit test to fail, and then we have to fix that :-)

@mikesheffler
Copy link
Contributor

I swear I'm not trying to be dense, but is this not covered by

TEST( SmartProjectionPoseFactor, smartFactorWithSensorBodyTransform )

in testSmartProjectionPoseFactor.cpp?

I'm suddenly interested because I'm using SmartProjectionPoseFactor<Cal3_S2> with a sensor_to_body transform, and I'm having a hell of a time.

I'm sure I'm just putting some garbage data in somewhere, but I figure it's worth asking ... 😁

@mikesheffler
Copy link
Contributor

Ah. Did you have this (issue number 41 from the bitbucket site) in mind? What kind of test did you need?

@dellaert
Copy link
Member Author

Just a test that checks that the projections are being done correctly if the camera is offset. Including derivatives

@dellaert dellaert mentioned this issue Jul 7, 2020
Closed
26 tasks
@varunagrawal varunagrawal mentioned this issue Jul 7, 2020
Merged
@ProfFan
Copy link
Collaborator

ProfFan commented Jul 11, 2020

Closed by #379, please reopen if not :)

@ProfFan ProfFan closed this as completed Jul 11, 2020
varunagrawal added a commit that referenced this issue Jan 2, 2021
@varunagrawal
Squashed 'wrap/' changes from a9ad4f504..8770e3c7e
746f6bb 
8770e3c7e Merge pull request #20 from borglab/fix/pybind-include
8c3c83618 proper placement of pybind11 include

git-subtree-dir: wrap
git-subtree-split: 8770e3c7eaa11819f143c11a455092b34c7289a0
varunagrawal added a commit that referenced this issue Jan 4, 2021
@varunagrawal
Squashed 'wrap/' changes from dfa624e77..09f8bbf71
7cc7232 
09f8bbf71 Merge pull request #25 from borglab/fix/function-name
0dbfb6c13 fix function name to be the correct one
f69f8b01f Merge pull request #24 from borglab/fix/pip
6519a6627 use pip install to overcome superuser issues
b11ecf4e8 Merge pull request #23 from borglab/fix/remove-pip-args
813030108 remove pip-args since we are using setup.py
498d233e0 Merge pull request #22 from borglab/fix/package-install
846212ac3 set correct flags for installing gtwrap package
62161cd20 Merge pull request #21 from borglab/feature/script-vars
93be1d9f8 set script variables and move pybind11 loading so gtwrap can be used under gtsam
8770e3c7e Merge pull request #20 from borglab/fix/pybind-include
8c3c83618 proper placement of pybind11 include
a9ad4f504 Merge pull request #19 from borglab/feature/package
99d8a12c7 added more documentation
4cbec1579 change to macro so we don't have to deal with function scopes
b83e405b8 updates to completely install the package
38a64b3de new scripts which will be installed to bin directory
bf9646235 Merge pull request #18 from borglab/fix/cmake-min
c7c280099 Consistent cmake minimum required
42df58f62 Merge pull request #17 from borglab/fix/cleanup
e580b282d version bump
4ccd66fa5 More finegrained handling of Python version
6476fd710 Merge pull request #16 from borglab/feature/better-find-python
8ac1296a0 use setup.py to install dependencies
e9ac473be install dependencies and support versions of CMake<3.12
cf272dbd2 Merge pull request #15 from borglab/feature/utils
ffc9cc4f7 new utils to reduce boilerplate
20e8e8b7a Merge pull request #11 from borglab/feature/package
04b844bd6 use new version of FindPython and be consistent
3f9d7a32a Merge pull request #13 from borglab/add_license
c791075a6 Add LICENSE
517b67c46 correct working directory for setup.py
1b22b47ae move matlab.h to root directory
37b407214 Proper source directory path for use in other projects
61696dd5d configure PybindWrap within the cmake directory
1b91fc9af add config file so we can use find_package
a1e6f4f53 small typo
da9f351be updated README and housekeeping
64b8f78d5 files needed to allow for packaging
bddda7f54 package structure

git-subtree-dir: wrap
git-subtree-split: 09f8bbf7172ba8b1bd3d2484795743f16e1a5893
varunagrawal added a commit that referenced this issue Feb 17, 2022
@varunagrawal
Merge pull request #20 from varunagrawal/fix/hybrid-resize
4fe4c2f 
Hybrid Resize
@dinvincible98 dinvincible98 mentioned this issue May 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ProfFan @dellaert @mikesheffler