ephemeral: Use SMBIOS credentials for systemd units #107
Conversation
Create a new credentials module that consolidates systemd credential injection functionality. Assisted-by: Claude Code (Sonnet 4.5) Signed-off-by: Colin Walters <walters@verbum.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a significant improvement, refactoring the ephemeral mode to use SMBIOS credentials for systemd units instead of writing them to the guest filesystem. This aligns it with the libvirt mode and addresses potential issues with ConditionFirstBoot. The consolidation of logic into a new credentials module is also a great step for maintainability. The changes are well-executed and align with the PR's goals. I have one minor suggestion to improve code clarity.
cgwalters
force-pushed
the
extra-unit-ephemeral
branch
from
cc495a9 to
af46809
Compare
|
Cool, to-disk works now, will do more testing about image tomorrow, thank you for the quickly fixing! |
|
OK this doesn't work on stream9 because there's no support for |
Fix ephemeral mode to use SMBIOS credentials (systemd.extra-unit.*) instead of writing systemd units directly to `/run/source-image/etc/systemd/system/`. This addresses ConditionFirstBoot issues on Fedora CoreOS where directly written units trigger systemd preset cleanup. The libvirt mode already uses SMBIOS credentials successfully. This change aligns ephemeral mode with that proven approach. Fixes: bootc-dev#106 Assisted-by: Claude Code (Sonnet 4.5) Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
extra-unit-ephemeral
branch
from
af46809 to
3f1e614
Compare
|
Well I just hacked it for now in |
3 participants
Clean up systemd credentials handling
Create a new credentials module that consolidates systemd credential
injection functionality.
Assisted-by: Claude Code (Sonnet 4.5)
Signed-off-by: Colin Walters walters@verbum.org
ephemeral: Use SMBIOS credentials for systemd units
Fix ephemeral mode to use SMBIOS credentials (systemd.extra-unit.*) instead
of writing systemd units directly to
/run/source-image/etc/systemd/system/.This addresses ConditionFirstBoot issues on Fedora CoreOS where directly
written units trigger systemd preset cleanup.
The libvirt mode already uses SMBIOS credentials successfully. This change
aligns ephemeral mode with that proven approach.
Fixes: #106
Assisted-by: Claude Code (Sonnet 4.5)
Signed-off-by: Colin Walters walters@verbum.org