-
Notifications
You must be signed in to change notification settings - Fork 126
Fix compilation when building with msvc's new preprocessor #667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Perhaps, it's better to #define BOOST_MP_LIT(P, N) BOOST_JOIN(operator"", BOOST_JOIN(P, N)) This way grepping for |
I think this would be better |
fixes the following error: ``` 1>time.cpp 1>D:\work-pps\boost_1_87_0\boost\multiprecision\cpp_int\literals.hpp(270,1): warning C5103: pasting '""_cppi' and '128' does not result in a valid preprocessing token 1>(compiling source file '../src/time.cpp') 1> D:\work-pps\boost_1_87_0\boost\multiprecision\cpp_int\literals.hpp(252,9): 1> in expansion of macro 'BOOST_MP_DEFINE_SIZED_CPP_INT_LITERAL' 1> D:\work-pps\boost_1_87_0\boost\config\helper_macros.hpp(33,9): 1> in expansion of macro 'BOOST_JOIN' 1> D:\work-pps\boost_1_87_0\boost\config\helper_macros.hpp(34,9): 1> in expansion of macro 'BOOST_DO_JOIN' 1> D:\work-pps\boost_1_87_0\boost\config\helper_macros.hpp(35,9): 1> in expansion of macro 'BOOST_DO_JOIN2' 1>D:\work-pps\boost_1_87_0\boost\multiprecision\cpp_int\literals.hpp(270,1): error C2988: unrecognizable template declaration/definition ```
applied. This way it's better |
Thanks. I approved the CI run |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #667 +/- ##
=======================================
Coverage 94.1% 94.1%
=======================================
Files 279 279
Lines 28979 28979
=======================================
Hits 27253 27253
Misses 1726 1726
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
I was about to ping... there is a less intrusive option also: operator BOOST_JOIN(""_cppi, Bits) to: BOOST_JOIN(operator ""_cppi, Bits) even this one, as there were no reason to use BOOST_JOIN there: operator ""_cppi##Bits |
let me know if I should create a new pr and remove |
I think it's fine. We can still grep for operator "" in the changes from this PR which we weren't able to do previously. |
fixes the following error when standard conforming preprocessor is enabled (
/Zc:preprocessor
option)