refactor: reuse prebuilt offramp arguments in gas estimation

[prestoalvarez]

Summary

• drop the redundant reconstruction of offrampArgs when estimating create-order gas
• rely on the object returned by createOfframpOrder, keeping the logic single-sourced

Summary by CodeRabbit

• Refactor
  • Internal optimization of gas cost calculation logic in the gateway client to reduce redundant argument handling while maintaining identical functionality.

[vercel]

@prestoalvarez is attempting to deploy a commit to the distributed-crafts Team on Vercel.

A member of the Team first needs to authorize it.

[gemini-code-assist]

Summary of Changes

Hello @prestoalvarez, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the gas estimation process for offramp order creation. By reusing existing argument structures rather than recreating them, the change enhances code consistency and reduces potential for discrepancies, leading to a more robust and maintainable codebase.

Highlights

• Gas Estimation Refactoring: The pull request refactors the gas estimation logic for creating offramp orders by eliminating the redundant reconstruction of offrampArgs.
• Argument Reuse: Instead of rebuilding the offrampArgs object, the change now directly reuses the pre-built arguments returned by createOfframpOrder, ensuring a single source of truth for these arguments.
• Code Simplification: This change simplifies the code in sdk/src/gateway/client.ts by removing unnecessary object manipulation and improving clarity.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[coderabbitai]

Walkthrough

The PR refactors gas cost estimation in the SDK gateway client by reusing pre-built offramp arguments directly from offrampOrder.offrampArgs instead of reconstructing them with an explicit owner override. The gas estimation logic remains functionally unchanged.

Changes

Cohort / File(s)	Summary
Offramp gas cost estimation refactoring sdk/src/gateway/client.ts	Modified getOfframpCreateOrderGasCost to reuse pre-built offrampArgs directly instead of reconstructing them with explicit owner override.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• feat: fetchOfframpLiquidity method and add orderOwner argument in ABI #587: Introduces orderOwner field to offrampArgs structure that this PR now reuses directly.
• chore: fix types #736: Standardizes field naming in offrampArgs (including orderOwner transformation) that impacts how pre-built args are structured.
• fix: check eth estimate in offramp #758: Also modifies gas estimation logic for offramp order creation in the same file, affecting the gas cost calculation pathway.

Suggested reviewers

• nakul1010
• slavastartsev
• gregdhill

Poem

🐰 A rabbit hops through args with glee,
No more rebuilding—reuse, you see!
From offrampOrder, we pluck with care,
The owner's already nestled there! 🥕
Simpler code makes logic clear,
Our refactored path draws near!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "refactor: reuse prebuilt offramp arguments in gas estimation" directly and accurately describes the main change in the pull request. The change involves reusing the offrampArgs from offrampOrder instead of reconstructing them in the getOfframpCreateOrderGasCost function, which is exactly what the title conveys. The title is specific, clear, and concise at 8 words, allowing a teammate to quickly understand that this PR eliminates redundant argument reconstruction during gas estimation without requiring them to read the full changeset details.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b605eff and 179d220.

📒 Files selected for processing (1)

• sdk/src/gateway/client.ts (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-06-17T11:18:53.195Z

Learnt from: slavastartsev
Repo: bob-collective/bob PR: 634
File: sdk/src/gateway/client.ts:136-140
Timestamp: 2025-06-17T11:18:53.195Z
Learning: The codebase has a requirement not to introduce discriminated unions in the Gateway SDK client methods, including the getQuote method return types in sdk/src/gateway/client.ts.

Applied to files:

• sdk/src/gateway/client.ts

🔇 Additional comments (1)

sdk/src/gateway/client.ts (1)

289-290: Excellent refactor—eliminates redundant arg reconstruction.

This change correctly reuses the pre-built offrampArgs from createOfframpOrder (which already sets the owner at line 566) instead of redundantly reconstructing them. This follows the DRY principle and maintains a single source of truth for argument construction.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Code Review

This is a good refactoring that simplifies the gas estimation logic for offramp orders. By reusing the offrampArgs object returned by createOfframpOrder, you've removed redundant code that was unnecessarily reconstructing the arguments. This change makes the code more concise and easier to maintain by keeping the argument creation logic single-sourced. The implementation is correct and improves code quality.