-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix detection of runtime limits for accessors #3335
Conversation
Test262 conformance changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! :)
adb0c53
to
b78befb
Compare
b78befb
to
961d67e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3335 +/- ##
==========================================
+ Coverage 49.44% 49.56% +0.11%
==========================================
Files 446 446
Lines 43862 43730 -132
==========================================
- Hits 21686 21673 -13
+ Misses 22176 22057 -119
☔ View full report in Codecov by Sentry. |
This bug was reported on our Discord server, so it doesn't have an issue associated with it.
Fixes runtime limits detection for accessors, since we were detecting those from the
Call
related ops, but property accessors are directly called from Rust code.