Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detection of runtime limits for accessors #3335

Merged
merged 5 commits into from
Oct 3, 2023
Merged

Conversation

jedel1043
Copy link
Member

This bug was reported on our Discord server, so it doesn't have an issue associated with it.

Fixes runtime limits detection for accessors, since we were detecting those from the Call related ops, but property accessors are directly called from Rust code.

@jedel1043 jedel1043 added bug Something isn't working vm Issues and PRs related to the Boa Virtual Machine. labels Oct 2, 2023
@jedel1043 jedel1043 added this to the v0.18.0 milestone Oct 2, 2023
@jedel1043 jedel1043 requested a review from a team October 2, 2023 08:38
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Test262 conformance changes

Test result main count PR count difference
Total 95,574 95,574 0
Passed 75,273 75,273 0
Ignored 19,482 19,482 0
Failed 819 819 0
Panics 0 0 0
Conformance 78.76% 78.76% 0.00%

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@HalidOdat HalidOdat requested a review from a team October 2, 2023 11:23
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (7445367) 49.44% compared to head (b37326d) 49.56%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3335      +/-   ##
==========================================
+ Coverage   49.44%   49.56%   +0.11%     
==========================================
  Files         446      446              
  Lines       43862    43730     -132     
==========================================
- Hits        21686    21673      -13     
+ Misses      22176    22057     -119     
Files Coverage Δ
boa_engine/src/object/internal_methods/function.rs 76.19% <100.00%> (+0.78%) ⬆️
boa_engine/src/vm/code_block.rs 50.39% <ø> (+0.78%) ⬆️
boa_engine/src/vm/opcode/call/mod.rs 24.32% <ø> (-0.57%) ⬇️
boa_engine/src/vm/opcode/new/mod.rs 75.00% <ø> (+19.64%) ⬆️
boa_engine/src/vm/mod.rs 62.00% <70.00%> (+0.57%) ⬆️

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jedel1043 jedel1043 requested a review from nekevss October 3, 2023 02:21
@nekevss nekevss added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit acdc5f4 Oct 3, 2023
14 checks passed
@jedel1043 jedel1043 deleted the fix-runtime-limits branch October 7, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vm Issues and PRs related to the Boa Virtual Machine.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants