Add additional checks and extract function

boa_engine/src/object/internal_methods/function.rs

@@ -89,6 +89,9 @@ pub(crate) fn native_function_call(
     args: &[JsValue],
     context: &mut Context<'_>,
 ) -> JsResult<JsValue> {
+    // We technically don't need this since native functions don't push any new frames to the
+    // vm, but we'll eventually have to combine the native stack with the vm stack.
+    context.check_runtime_limits()?;
     let this_function_object = obj.clone();
     let object = obj.borrow();
 
@@ -135,6 +138,9 @@ fn native_function_construct(
     new_target: &JsObject,
     context: &mut Context<'_>,
 ) -> JsResult<JsObject> {
+    // We technically don't need this since native functions don't push any new frames to the
+    // vm, but we'll eventually have to combine the native stack with the vm stack.
+    context.check_runtime_limits()?;
     let this_function_object = obj.clone();
     let object = obj.borrow();
 

boa_engine/src/vm/code_block.rs

@@ -1019,16 +1019,7 @@ impl JsObject {
         args: &[JsValue],
         context: &mut Context<'_>,
     ) -> JsResult<JsValue> {
-        if context.vm.runtime_limits.recursion_limit() <= context.vm.frames.len() {
-            return Err(JsNativeError::runtime_limit()
-                .with_message("exceeded maximum number of recursive calls")
-                .into());
-        }
-        if context.vm.runtime_limits.stack_size_limit() <= context.vm.stack.len() {
-            return Err(JsNativeError::runtime_limit()
-                .with_message("exceeded maximum call stack length")
-                .into());
-        }
+        context.check_runtime_limits()?;
         let old_realm = context.realm().clone();
 
         let context = &mut context.guard(move |ctx| {
@@ -1180,16 +1171,7 @@ impl JsObject {
         this_target: &JsValue,
         context: &mut Context<'_>,
     ) -> JsResult<Self> {
-        if context.vm.runtime_limits.recursion_limit() <= context.vm.frames.len() {
-            return Err(JsNativeError::runtime_limit()
-                .with_message("exceeded maximum number of recursive calls")
-                .into());
-        }
-        if context.vm.runtime_limits.stack_size_limit() <= context.vm.stack.len() {
-            return Err(JsNativeError::runtime_limit()
-                .with_message("exceeded maximum call stack length")
-                .into());
-        }
+        context.check_runtime_limits()?;
         let old_realm = context.realm().clone();
         let context = &mut context.guard(move |ctx| {
             ctx.enter_realm(old_realm);

boa_engine/src/vm/mod.rs

@@ -10,7 +10,7 @@ use crate::{
     environments::{DeclarativeEnvironment, EnvironmentStack},
     script::Script,
     vm::code_block::Readable,
-    Context, JsError, JsNativeErrorKind, JsObject, JsResult, JsValue, Module,
+    Context, JsError, JsNativeErrorKind, JsObject, JsResult, JsValue, Module, JsNativeError,
 };
 
 use boa_gc::{custom_trace, Finalize, Gc, Trace};
@@ -412,4 +412,22 @@ impl Context<'_> {
             }
         }
     }
+
+    /// Checks if we haven't exceeded the defined runtime limits.
+    pub(crate) fn check_runtime_limits(&self) -> JsResult<()> {
+        // Must throw if the number of recursive calls exceeds the defined limit.
+        if self.vm.runtime_limits.recursion_limit() <= self.vm.frames.len() {
+            return Err(JsNativeError::runtime_limit()
+                .with_message("exceeded maximum number of recursive calls")
+                .into());
+        }
+        // Must throw if the stack size exceeds the defined maximum length.
+        if self.vm.runtime_limits.stack_size_limit() <= self.vm.stack.len() {
+            return Err(JsNativeError::runtime_limit()
+                .with_message("exceeded maximum call stack length")
+                .into());
+        }
+
+        Ok(())
+    }
 }