[Merged by Bors] - Make the wasmbind feature of the chrono crate optional
#2810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razican
added
dependencies
Razican
requested review from
jasonwilliams,
HalidOdat,
RageKnify,
raskad,
jedel1043 and
nekevss
Razican
changed the title
wasmbind feature of the chrono crate optionalwasmbind feature of the chrono crate optional
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #2810 +/- ##
=======================================
Coverage 51.31% 51.31%
=======================================
Files 416 416
Lines 41213 41213
=======================================
Hits 21149 21149
Misses 20064 20064
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jedel1043
reviewed
Apr 11, 2023
bors bot
pushed a commit
that referenced
this pull request
Apr 11, 2023
This Pull Request fixes/closes #2475. It changes the following: - Do not use the `wasmbind` feature by default in the `chrono` crate. This can be enabled selectively if needed. - Updated the `boa_wasm` crate to use this new approach. I'm interested on knowing if this fixes @lastmjs's issue, and on checking with the team if this is the best approach to solve it.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
wasmbind feature of the chrono crate optionalwasmbind feature of the chrono crate optional
|
This worked! Much appreciated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #2475.
It changes the following:
wasmbindfeature by default in thechronocrate. This can be enabled selectively if needed.boa_wasmcrate to use this new approach.I'm interested on knowing if this fixes @lastmjs's issue, and on checking with the team if this is the best approach to solve it.