New version of chrono breaks wasm32-unknown-unknown

[lastmjs]

Describe the bug

chrono = "0.4.23" introduces dependencies on wasm-bindgen (one of its default features is wasmbind) when compiling for the wasm32-unknown-unknown environment. Because these wasm-bindgen imports are not available in that environment by default, our code cannot be deployed to our environment.

This is related to the work done here: #1670

To Reproduce

Compile a simple Boa app to wasm32-unknown-unknown and attempt to run it in an environment (for example wasmtime) which has no wasm-bindgen support.

Expected behavior

Deploying a Boa application compiled with the wasm32-unknown-unknown target should work fine in an environment that doesn't have wasm-bindgen support.

Build environment (please complete the following information):

• OS: Ubuntu
• Version: 20.04
• Target triple: wasm32-unknown-unknown
• Rustc version: rustc 1.65.0 (897e37553 2022-11-02)

[lastmjs]

I can confirm from my own fork of Boa that changing the chrono dependency in the Cargo.toml file to chrono = { version = "0.4.23", default-features = false, features = ["clock", "std"] } resolves the issue. That's just a quick fix in our own fork.

[Razican]

Wouldn't this be a chrono bug?

[lastmjs]

I don't think so, Boa should be able to compile and run with wasm32-unknown-unknown. It won't run in our environment because it uses chrono's default features. So we need a way to allow the developer to turn off the chrono wasmbind feature when compiling to wasm32-unknown-unknown.

wasm32-unknown-unknown shouldn't assume wasm-bindgen support, or there should be a way to turn those features off entirely.

It's not a bug in chrono, it's just a new feature that they enabled by default, but that doesn't work for a strict wasm32-unknown-unknown environment.

[lastmjs]

This is still an issue, the wasmbind feature of chrono should be optional in Boa.

Here's the current code in boa_engine/Cargo.toml:

chrono = { version = "0.4.24", default-features = false, features = ["clock", "std", "wasmbind"] }

Making wasmbind an optional feature of chrono in boa_engine would solve my problem.