Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Cleanup intrinsics and move to realm #2555

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - Cleanup intrinsics and move to realm #2555

wants to merge 5 commits into from

Conversation

jedel1043
Copy link
Member

Small (ish?) step towards having proper realm records

This PR changes the following:

@jedel1043 jedel1043 added this to the v0.17.0 milestone Jan 23, 2023
@github-actions
Copy link

github-actions bot commented Jan 23, 2023 •
edited
Loading

Test262 conformance changes

Test result main count PR count difference
Total 94,205 94,205 0
Passed 70,722 70,728 +6
Ignored 18,622 18,622 0
Failed 4,861 4,855 -6
Panics 0 0 0
Conformance 75.07% 75.08% +0.01%
Fixed tests (6): 
test/intl402/DateTimeFormat/proto-from-ctor-realm.js [strict mode] (previously Failed)
test/intl402/DateTimeFormat/proto-from-ctor-realm.js (previously Failed)
test/built-ins/Function/prototype/property-order.js [strict mode] (previously Failed)
test/built-ins/Function/prototype/property-order.js (previously Failed)
test/harness/detachArrayBuffer-host-detachArrayBuffer.js [strict mode] (previously Failed)
test/harness/detachArrayBuffer-host-detachArrayBuffer.js (previously Failed)

@jedel1043 jedel1043 mentioned this pull request Jan 23, 2023
Closed
@codecov
Copy link

codecov bot commented Jan 23, 2023 •
edited
Loading

Codecov Report

Merging #2555 (7bf75fb) into main (ddf00c8) will decrease coverage by 0.34%.
The diff coverage is 89.74%.

@@            Coverage Diff             @@
##             main    #2555      +/-   ##
==========================================
- Coverage   49.87%   49.53%   -0.34%     
==========================================
  Files         380      376       -4     
  Lines       37945    37734     -211     
==========================================
- Hits        18925    18693     -232     
- Misses      19020    19041      +21
Impacted Files Coverage Δ
boa_cli/src/main.rs 0.93% <0.00%> (-0.01%) ⬇️
boa_engine/src/class.rs 0.00% <0.00%> (ø)
boa_engine/src/object/builtins/jsgenerator.rs 0.00% <0.00%> (ø)
boa_engine/src/object/builtins/jsmap_iterator.rs 0.00% <ø> (ø)
boa_engine/src/object/builtins/jsset_iterator.rs 0.00% <ø> (ø)
boa_engine/src/object/builtins/jstypedarray.rs 0.00% <ø> (ø)
boa_engine/src/object/jsobject.rs 65.48% <0.00%> (ø)
boa_engine/src/vm/opcode/await_stm/mod.rs 0.00% <ø> (ø)
boa_engine/src/vm/opcode/define/class/getter.rs 0.00% <0.00%> (ø)
boa_engine/src/vm/opcode/define/class/method.rs 0.00% <0.00%> (ø)
... and 82 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

raskad
raskad approved these changes Jan 28, 2023
View reviewed changes
Copy link
Member

@raskad raskad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!

I really like the new builtin initialization. The separated traits make it clear what exactly the builtin object is and how it is used.

@jedel1043 jedel1043 requested a review from nekevss January 31, 2023 16:52
nekevss
nekevss approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 😄

@jedel1043
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Feb 1, 2023
@jedel1043
Cleanup intrinsics and move to realm (#2555)
c039283 
Small (ish?) step towards having proper realm records 

This PR changes the following:

- Moves `Intrinsics` to `Realm`.
- Cleans up the initialization logic of our intrinsics to not depend on `Context`, unblocking things like #2314.
- Adds hooks to initialize the global object and the global this per the corresponding [`InitializeHostDefinedRealm ( )`](https://tc39.es/ecma262/#sec-initializehostdefinedrealm) hook. Though, this is currently broken because the vm uses `GlobalPropertyMap` instead of the `JsObject` API to initialize global properties.
@bors
Copy link

bors bot commented Feb 1, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Cleanup intrinsics and move to realm [Merged by Bors] - Cleanup intrinsics and move to realm Feb 1, 2023
@bors bors bot closed this Feb 1, 2023
@bors bors bot deleted the new-intrinsics branch February 1, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekevss nekevss nekevss approved these changes

@raskad raskad raskad approved these changes

@Razican Razican Awaiting requested review from Razican

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@HalidOdat HalidOdat Awaiting requested review from HalidOdat

@RageKnify RageKnify Awaiting requested review from RageKnify

Assignees
No one assigned
Labels
API technical debt
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jedel1043 @raskad @nekevss