create intrinsics lazily, after we know parsing is successful. fixes #2307 #2314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will probably benefit fom #2283, since that'll separate error creation from the context :) |
bors bot
pushed a commit
that referenced
this pull request
Feb 1, 2023
Small (ish?) step towards having proper realm records This PR changes the following: - Moves `Intrinsics` to `Realm`. - Cleans up the initialization logic of our intrinsics to not depend on `Context`, unblocking things like #2314. - Adds hooks to initialize the global object and the global this per the corresponding [`InitializeHostDefinedRealm ( )`](https://tc39.es/ecma262/#sec-initializehostdefinedrealm) hook. Though, this is currently broken because the vm uses `GlobalPropertyMap` instead of the `JsObject` API to initialize global properties.
|
@jasonwilliams Do you have some progress on this? We can probably rebase this since the new error types makes this an easier change. |
|
Thanks for pinging me on this, I think we can close this as it needs a rethink. If someone creates a new error handler and we parse incorrect syntax, we would need to execute that instead of the default syntaxError which may require us having the realm initiated. So this may not work as I expected when I started this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves intrinsics from the beginning to after parsing. With this change we can "fail fast" if there's a parsing/syntax error. Currently intrinsics need to be built before parsing the code which is wasteful.
The syntax errors are hardcoded to a JSValue as not to use the environment when we already know what the error type will be.
Before
After
Fixes: #2307