Skip to content

fix(code-review): remove dead Batch-apply option from patch menu#2225

Open
alexeyv wants to merge 1 commit intomainfrom
fix/code-review-patch-menu
Open

fix(code-review): remove dead Batch-apply option from patch menu#2225
alexeyv wants to merge 1 commit intomainfrom
fix/code-review-patch-menu

Conversation

@alexeyv
Copy link
Copy Markdown
Collaborator

@alexeyv alexeyv commented Apr 7, 2026

Summary

Removes the Batch-apply all option (option 0) from the code review patch-handling menu in step-04-present.md. The option had been silently dead since the same PR that introduced it.

Why

The option was added in 9c3e280 (PR #2055) with the instruction to "apply all non-controversial patches without per-finding confirmation. Skip any finding that requires judgment."

But two commits earlier in the same PR, step-03-triage.md had been refactored to guarantee that patch findings are unambiguous by definition:

decision_needed — There is an ambiguous choice that requires human input.
patch — Code issue that is fixable without human input. The correct fix is unambiguous.

So by the time findings reach the patch menu, there is nothing left to "skip" — anything controversial has already been routed to the decision-needed bucket. The "non-controversial only" carve-out had no work to do, and option 0 collapsed to a duplicate of option 1 with confusing branding. Two options for the same intent under different labels left users wondering which was which (which is what surfaced this).

What changed

  • Delete option 0 (Batch-apply all) and the >3 patch findings conditional that gated it.
  • Rename option 1 Fix them automaticallyApply every patch, with explicit scope: "fix all of them now, no per-finding confirmation. Defer and decision-needed items are not touched."
  • Rename option 3 Walk through eachWalk through each patch for the same scope clarity.
  • Unify the count placeholder: replace <Z> with the existing <P> patch-count placeholder. <Z> was an undocumented duplicate.
  • Strip stale (or "0" for batch) notes from the three HALT lines.
  • Switch handling-line labels from Option 1/2/3 to descriptive labels matching the menu wording.

Net diff: +14 / -17 in one file. No behavior change for any path that was ever reachable in practice.

Test plan

  • npm ci && npm run quality passes locally (204 install tests, 0 broken refs, skill validator strict mode pass).
  • Run bmad-code-review against a story with patch findings — verify the menu shows three options, no option 0, the count renders, and the scope statement appears.
  • Run against a story with mixed defer + patch findings — verify defer items are not touched by the apply path.
  • Run in no-spec mode — verify the two-option menu (Apply every patch / Walk through each patch) renders.

The Batch-apply option (added in 9c3e280) was instructed to "skip
any finding that requires judgment" — but step-03-triage already
guarantees patch findings are unambiguous (the decision-needed
bucket exists precisely to absorb ambiguous ones). The option had
no distinct work to do that option 1 did not already cover, and
its label suggested a meaningful difference that did not exist.

- Delete option 0 and the >3 findings conditional
- Rename "Fix them automatically" -> "Apply every patch", with
  explicit scope (patches only; defer/decision-needed untouched)
- Rename "Walk through each" -> "Walk through each patch" for the
  same scope clarity
- Unify <Z> placeholder with the existing <P> patch count
- Strip stale (or "0" for batch) notes from HALT lines
@augmentcode
Copy link
Copy Markdown

augmentcode bot commented Apr 7, 2026

🤖 Augment PR Summary

Summary: This PR cleans up the code-review patch-handling menu text by removing the dead “Batch-apply all” path and clarifying the remaining choices.

Changes:

  • Drops option 0 and the “>3 patch findings” conditional that gated it
  • Renames option wording to be explicit about scope (apply all patches vs. walkthrough)
  • Unifies the patch-count placeholder by switching from <Z> to the existing <P>
  • Removes stale “(or 0 for batch)” notes and updates the handling labels to match the menu

Technical Notes: This is an instruction-text update in step-04-present.md; it should not change any reachable behavior, only reduce user confusion.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9f2c3258-4355-4036-8114-973d6a640add

📥 Commits

Reviewing files that changed from the base of the PR and between c46502f and d635edb.

📒 Files selected for processing (1)
  • src/bmm-skills/4-implementation/bmad-code-review/steps/step-04-present.md

📝 Walkthrough

Walkthrough

This PR modifies patch-handling menu options and prompts in a code review workflow step, removing batch processing support and renumbering interactive choices, with adjusted wording for patch application behavior and action item handling.

Changes

Cohort / File(s) Summary
Patch Menu Updates
src/bmm-skills/4-implementation/bmad-code-review/steps/step-04-present.md
Removed batch processing (0) option from both decision-needed and patch HALT prompts. Renumbered menu options to 1-2 with conditional behavior: when {spec_file} is set, options are 1) Apply every patch and 2) Leave as action items; otherwise 1) Apply every patch and 2) Walk through each patch. Updated completion text for post-apply reporting and re-prompt wording after walkthrough.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • #2055: Modifies the same patch-handling menu and interactive choices in step-04-present.md.
  • #2013: Modifies patch/apply wording and menu handling for presenting patch options in the same file.

Suggested reviewers

  • bmadcode
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix(code-review): remove dead Batch-apply option from patch menu' directly and accurately summarizes the main change: removing a defunct option from the patch menu.
Description check ✅ Passed The description is comprehensive and directly related to the changeset, explaining the rationale, implementation details, and testing approach for removing the dead Batch-apply option.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/code-review-patch-menu

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant