fix(code-review): remove dead Batch-apply option from patch menu#2225
fix(code-review): remove dead Batch-apply option from patch menu#2225
Conversation
The Batch-apply option (added in 9c3e280) was instructed to "skip any finding that requires judgment" — but step-03-triage already guarantees patch findings are unambiguous (the decision-needed bucket exists precisely to absorb ambiguous ones). The option had no distinct work to do that option 1 did not already cover, and its label suggested a meaningful difference that did not exist. - Delete option 0 and the >3 findings conditional - Rename "Fix them automatically" -> "Apply every patch", with explicit scope (patches only; defer/decision-needed untouched) - Rename "Walk through each" -> "Walk through each patch" for the same scope clarity - Unify <Z> placeholder with the existing <P> patch count - Strip stale (or "0" for batch) notes from HALT lines
🤖 Augment PR SummarySummary: This PR cleans up the code-review patch-handling menu text by removing the dead “Batch-apply all” path and clarifying the remaining choices. Changes:
Technical Notes: This is an instruction-text update in 🤖 Was this summary useful? React with 👍 or 👎 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR modifies patch-handling menu options and prompts in a code review workflow step, removing batch processing support and renumbering interactive choices, with adjusted wording for patch application behavior and action item handling. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Removes the
Batch-apply alloption (option 0) from the code review patch-handling menu instep-04-present.md. The option had been silently dead since the same PR that introduced it.Why
The option was added in 9c3e280 (PR #2055) with the instruction to "apply all non-controversial patches without per-finding confirmation. Skip any finding that requires judgment."
But two commits earlier in the same PR,
step-03-triage.mdhad been refactored to guarantee thatpatchfindings are unambiguous by definition:So by the time findings reach the patch menu, there is nothing left to "skip" — anything controversial has already been routed to the
decision-neededbucket. The "non-controversial only" carve-out had no work to do, and option 0 collapsed to a duplicate of option 1 with confusing branding. Two options for the same intent under different labels left users wondering which was which (which is what surfaced this).What changed
Batch-apply all) and the>3 patch findingsconditional that gated it.Fix them automatically→Apply every patch, with explicit scope: "fix all of them now, no per-finding confirmation. Defer and decision-needed items are not touched."Walk through each→Walk through each patchfor the same scope clarity.<Z>with the existing<P>patch-count placeholder.<Z>was an undocumented duplicate.(or "0" for batch)notes from the three HALT lines.Option 1/2/3to descriptive labels matching the menu wording.Net diff: +14 / -17 in one file. No behavior change for any path that was ever reachable in practice.
Test plan
npm ci && npm run qualitypasses locally (204 install tests, 0 broken refs, skill validator strict mode pass).bmad-code-reviewagainst a story with patch findings — verify the menu shows three options, no option 0, the count renders, and the scope statement appears.no-specmode — verify the two-option menu (Apply every patch/Walk through each patch) renders.