fix(code-review): restore actionable review output with interactive choices#2055
fix(code-review): restore actionable review output with interactive choices#2055
Conversation
…hoices The March 15 rewrite (PR #2007) removed the ability to auto-fix patches, create action items in story files, and handle deferred/spec findings. This restores interactive post-review actions: - Deferred findings: auto-written to deferred-work.md and checked off in story - Intent gap/bad spec: conversation with downgrade-to-patch, patch-spec, reset-to-ready-for-dev, or dismiss options - Patch findings: fix automatically, create action items, or show details Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Thanks, I caught this as well. |
|
@coderabbitai review |
🤖 Augment PR SummarySummary: Restores actionable behavior to the code review workflow’s final step by reintroducing interactive “what next?” decisions after findings are presented. Changes:
deferred_work_file frontmatter variable pointing at {implementation_artifacts}/deferred-work.md to standardize deferred output.
🤖 Was this summary useful? React with 👍 or 👎 |
src/bmm-skills/4-implementation/bmad-code-review/steps/step-04-present.md
Outdated
Show resolved
Hide resolved
src/bmm-skills/4-implementation/bmad-code-review/steps/step-04-present.md
Outdated
Show resolved
Hide resolved
src/bmm-skills/4-implementation/bmad-code-review/steps/step-04-present.md
Outdated
Show resolved
Hide resolved
src/bmm-skills/4-implementation/bmad-code-review/steps/step-04-present.md
Outdated
Show resolved
Hide resolved
📝 WalkthroughWalkthroughUpdated Step 4 workflow instructions for "Present and Act" to automatically append Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/bmm-skills/4-implementation/bmad-code-review/steps/step-04-present.md (1)
16-18: Consider acknowledging failed layers in the clean review shortcut.Step-03 triage (lines 41-46 in step-03-triage.md) warns the user when zero findings remain but
{failed_layers}is non-empty, indicating the review may be incomplete. This shortcut doesn't reference that warning. Consider adding a note that the clean review shortcut assumes step-03 already handled the failed layers warning.📝 Suggested clarification
### 1. Clean review shortcut -If zero findings remain after triage (all rejected or none raised): state that and end the workflow. +If zero findings remain after triage (all rejected or none raised): state that and end the workflow. (Note: step 3 will have already warned if any review layers failed.)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/bmm-skills/4-implementation/bmad-code-review/steps/step-04-present.md` around lines 16 - 18, Update the "Clean review shortcut" text in step-04-present.md to acknowledge failed layers: either add a short note that this shortcut assumes step-03 triage has already handled any {failed_layers} warnings, or explicitly instruct the reviewer to verify {failed_layers} is empty before ending the workflow; reference the Step-03 triage behavior mentioned in step-03-triage.md (the warning about non-empty {failed_layers}) so readers know where to check.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/bmm-skills/4-implementation/bmad-code-review/steps/step-04-present.md`:
- Around line 57-68: The Option 2 flow assumes a non-empty spec_file and will
fail when review_mode == "no-spec"; update the Option 2 handling in the step
that presents "How would you like to handle the {Z} patch findings?" to first
check that spec_file is present (non-empty) before attempting to add a "Review
Follow-ups (AI)" subsection to {spec_file}; if spec_file is empty (review_mode
== "no-spec") present a clear alternative (e.g., ask the user to choose another
option, create a downloadable patch/summary, or store follow-ups in a temporary
in-memory or output-only location) and do not attempt to write to {spec_file}.
Ensure the guard references the existing variables review_mode and spec_file and
is applied in the code path that implements Option 2.
---
Nitpick comments:
In `@src/bmm-skills/4-implementation/bmad-code-review/steps/step-04-present.md`:
- Around line 16-18: Update the "Clean review shortcut" text in
step-04-present.md to acknowledge failed layers: either add a short note that
this shortcut assumes step-03 triage has already handled any {failed_layers}
warnings, or explicitly instruct the reviewer to verify {failed_layers} is empty
before ending the workflow; reference the Step-03 triage behavior mentioned in
step-03-triage.md (the warning about non-empty {failed_layers}) so readers know
where to check.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: bfa38c4a-fef8-4515-89c3-9a3f9c864695
📒 Files selected for processing (1)
src/bmm-skills/4-implementation/bmad-code-review/steps/step-04-present.md
src/bmm-skills/4-implementation/bmad-code-review/steps/step-04-present.md
Outdated
Show resolved
Hide resolved
…/dismiss Replace 5-bucket classification (intent_gap, bad_spec, patch, defer, reject) with 4 pragmatic buckets. Findings always written to story file first. Decision-needed findings gate patch handling — resolve ambiguity before fixing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace undefined curly-brace placeholders with angle-bracket syntax, add HALT guard before patch menu, guard spec_file references for no-spec mode, and backtick category names for consistency.
… summary Add strong HALT guards after decision-needed and patch menus to prevent auto-progression. Add batch-apply option 0 for >3 patch findings. Prompt for defer reason and append to story file and deferred-work.md. Show boxed final summary with counts. Polish clean-review shortcut in triage.
Summary
deferred-work.mdand checked off in story file — no HITL turn needed[AI-Review][Severity]), or show detailsMotivation
The rewrite made the review step presentation-only, removing the ability to act on findings. This forced expensive upstream re-runs (create story = ~15 HITL turns, dev story = full cycle) even when a simple code patch would suffice. The new "downgrade to patch" option lets users reclassify spec findings into the patch bucket to avoid unnecessary re-runs.
Test plan
[AI-Review][Severity]format in story file🤖 Generated with Claude Code