Skip to content

fix(skill): validation cleanup for quick-flow skills#1997

Merged
alexeyv merged 2 commits intomainfrom
fix/quickflow-skill-validation-cleanup
Mar 14, 2026
Merged

fix(skill): validation cleanup for quick-flow skills#1997
alexeyv merged 2 commits intomainfrom
fix/quickflow-skill-validation-cleanup

Conversation

@alexeyv
Copy link
Copy Markdown
Collaborator

@alexeyv alexeyv commented Mar 14, 2026

Summary

Non-routine validation findings across 3 quick-flow skills:

bmad-quick-dev-new-preview:

  • PATH-01: Fixed 6 wrong step-to-step path references from within steps/ directory (./steps/step-XX.md should be ./step-XX.md)
  • STEP-06, PATH-04: Standard frontmatter and variable cleanup

bmad-quick-dev:

  • STEP-06: Removed name/description from all 6 step frontmatters
  • PATH-04: Inlined nextStepFile variables with mode-aware routing

bmad-quick-spec:

  • WF-01/WF-02: Removed name/description from workflow.md frontmatter
  • PATH-01: Replaced absolute self-references using {project-root}/_bmad/... for intra-skill paths with relative paths
  • STEP-06: Removed name/description from all 4 step frontmatters

Test plan

  • Skill validator passes with 0 findings for all 3 skills
  • Installer produces correct output
  • Repo test suite passes

🤖 Generated with Claude Code

bmad-quick-dev-new-preview: fix wrong step-to-step path references
from within steps/ directory, remove step frontmatter metadata and
intra-skill path variables.

bmad-quick-dev: remove step frontmatter metadata, inline nextStepFile
path variables as literal relative paths.

bmad-quick-spec: remove name/description from workflow.md frontmatter,
fix absolute self-references using {project-root} for intra-skill
paths, remove step frontmatter metadata.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@augmentcode
Copy link
Copy Markdown

augmentcode bot commented Mar 14, 2026

🤖 Augment PR Summary

Summary: Validation-focused cleanup across the Quick Flow “quick-dev” / “quick-spec” skills.

Changes:

  • Fixes incorrect intra-step path references in bmad-quick-dev-new-preview step files (remove the extra steps/ segment).
  • Removes redundant name/description frontmatter from quick-flow step/workflow files to match validator expectations.
  • Inlines step-routing and template paths that were previously stored as frontmatter variables.
Technical Notes: Intended to eliminate non-routine validator findings while keeping the workflows’ behavior and routing semantics unchanged.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@alexeyv alexeyv merged commit 6c83482 into main Mar 14, 2026
5 checks passed
@alexeyv alexeyv deleted the fix/quickflow-skill-validation-cleanup branch March 14, 2026 23:07
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 14, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This change removes YAML frontmatter fields (name, description, nextStepFile, templateFile) from workflow step Markdown files across three workflow variants (bmad-quick-dev-new-preview, bmad-quick-dev, bmad-quick-spec) and replaces template variable references with hardcoded relative paths for step navigation and template file locations.

Changes

Cohort / File(s) Summary
bmad-quick-dev-new-preview workflow steps
src/bmm/workflows/bmad-quick-flow/bmad-quick-dev-new-preview/steps/step-01-clarify-and-route.md, step-02-plan.md, step-03-implement.md, step-04-review.md, step-05-present.md
Removed frontmatter fields (name, description); updated NEXT section references to use relative paths without "steps/" prefix; hardcoded template path ../tech-spec-template.md in step-02-plan; expanded token-count handling flow in step-02-plan.
bmad-quick-dev-new-preview workflow config
src/bmm/workflows/bmad-quick-flow/bmad-quick-dev-new-preview/workflow.md
Removed templateFile path reference from Paths section, keeping only wipFile.
bmad-quick-dev workflow steps
src/bmm/workflows/bmad-quick-flow/bmad-quick-dev/steps/step-01-mode-detection.md, step-02-context-gathering.md, step-03-execute.md, step-04-self-check.md, step-05-adversarial-review.md, step-06-resolve-findings.md
Removed frontmatter fields (name, description, nextStepFile); replaced template variable references ({nextStepFile}, {nextStepFile_modeA}, {nextStepFile_modeB}) with hardcoded relative paths throughout NEXT sections and navigation references.
bmad-quick-spec workflow steps
src/bmm/workflows/bmad-quick-flow/bmad-quick-spec/steps/step-01-understand.md, step-02-investigate.md, step-03-generate.md, step-04-review.md
Removed frontmatter fields (name, description); replaced {templateFile} variable with hardcoded path ../tech-spec-template.md in step-01-understand.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • BMAD-METHOD#1986: Performs identical frontmatter field removals and replaces template/nextStepFile variables with hardcoded paths across workflow step Markdown files
  • BMAD-METHOD#1182: Modifies bmad quick-dev workflow step files, replacing templated variables with concrete step paths using the same filenames
  • BMAD-METHOD#1982: Applies the same edits pattern of removing name/description frontmatter and inlining template/nextStep path variables in step Markdown files

Suggested reviewers

  • bmadcode
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix(skill): validation cleanup for quick-flow skills' directly and clearly summarizes the main change: addressing validation findings across three quick-flow skills by cleaning up paths, frontmatter, and variables.
Description check ✅ Passed The description is directly related to the changeset, providing specific details about validation fixes across three skills (bmad-quick-dev-new-preview, bmad-quick-dev, bmad-quick-spec) with clear categorization of changes and test plans.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/quickflow-skill-validation-cleanup
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant