Skip to content

fix(skill): clean up bmad-create-ux-design validation findings#1983

Merged
alexeyv merged 2 commits intomainfrom
fix/create-ux-design-skill-cleanup
Mar 14, 2026
Merged

fix(skill): clean up bmad-create-ux-design validation findings#1983
alexeyv merged 2 commits intomainfrom
fix/create-ux-design-skill-cleanup

Conversation

@alexeyv
Copy link
Copy Markdown
Collaborator

@alexeyv alexeyv commented Mar 14, 2026

Summary

  • Remove installed_path and intra-skill template_path variable (PATH-02, PATH-04)
  • Prefix bare docs/** with {project-root} (PATH-03)
  • Inline undefined {status_file} and {default_output_file} references (REF-01)
  • Fix wrong config variable in output path (REF-02)

Test plan

  • Skill validator passes with 0 findings
  • Installer produces correct output
  • Repo test suite passes

🤖 Generated with Claude Code

alexeyv and others added 2 commits March 14, 2026 16:04
Remove installed_path and intra-skill template_path variable (PATH-02,
PATH-04), prefix bare docs/** with {project-root} (PATH-03), inline
undefined variable references (REF-01), fix wrong config variable in
output path (REF-02).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@alexeyv alexeyv merged commit 122ef9b into main Mar 14, 2026
5 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 14, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 67b6539e-a57e-4c55-890d-3e67b83cd1e9

📥 Commits

Reviewing files that changed from the base of the PR and between 9d17cee and 2b2b920.

📒 Files selected for processing (4)
  • src/bmm/workflows/2-plan-workflows/bmad-create-ux-design/steps/step-01-init.md
  • src/bmm/workflows/2-plan-workflows/bmad-create-ux-design/steps/step-01b-continue.md
  • src/bmm/workflows/2-plan-workflows/bmad-create-ux-design/steps/step-14-complete.md
  • src/bmm/workflows/2-plan-workflows/bmad-create-ux-design/workflow.md

📝 Walkthrough

Walkthrough

This PR refactors path references in the bmad-create-ux-design workflow, transitioning from installed/absolute paths to project-root relative paths and normalizing configuration. Changes affect template sourcing, documentation discovery, and artifact output locations across four workflow files.

Changes

Cohort / File(s) Summary
Workflow Configuration
src/bmm/workflows/2-plan-workflows/bmad-create-ux-design/workflow.md
Removed installed_path and template_path definitions from the Paths section, leaving default_output_file intact.
Workflow Step Updates
src/bmm/workflows/2-plan-workflows/bmad-create-ux-design/steps/step-01-init.md, step-01b-continue.md, step-14-complete.md
Updated path references: docs discovery changed to {project-root}/docs/**, template source changed to relative path ../ux-design-template.md, status variable switched from {output_folder} to {planning_artifacts}, and status loading changed to reference project workflow status file instead of workflow configuration.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • #1934: Converted the create-ux-design workflow to a native skill and normalized file paths and step references.
  • #1924: Made similar configuration changes removing installed_path and switching to relative path resolution.
  • #1975: Normalized internal path references from installed/absolute-style to project-relative paths within workflow files.

Suggested reviewers

  • bmadcode
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/create-ux-design-skill-cleanup
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant