refactor(skills): convert brainstorming to native skill

[alexeyv]

Summary

• convert src/core/workflows/brainstorming into the native-skill layout under src/core/workflows/bmad-brainstorming
• switch core and bmm help catalog entries to skill:bmad-brainstorming
• update the analyst agent menu entry to the renamed installed workflow path

Verification

• npm test
• installed into the local /Users/alex/src/bmad harness with the CLI and verified .claude/skills/bmad-brainstorming/
• ran before/after functional equivalence checks for fresh-session and continuation-session flows against old vs converted workflow files

[augmentcode]

🤖 Augment PR Summary

Summary: Migrates the core brainstorming workflow into a native skill directory (src/core/workflows/bmad-brainstorming) with a SKILL.md and type: skill manifest.

Updates: Repoints help catalog references and the analyst agent’s BP menu entry to the new bmad-brainstorming skill/workflow path.

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR migrates the brainstorming workflow to a new bmad-brainstorming directory structure. It establishes a new skill manifest, adds documentation, updates path resolution from installation-based to relative paths, and cleans up the old workflow manifest configuration.

Changes

Cohort / File(s)	Summary
Agent Configuration Update src/bmm/agents/analyst.agent.yaml	Updated workflow reference from brainstorming/workflow.md to bmad-brainstorming/workflow.md
New bmad-brainstorming Workflow src/core/workflows/bmad-brainstorming/SKILL.md, src/core/workflows/bmad-brainstorming/bmad-skill-manifest.yaml, src/core/workflows/bmad-brainstorming/workflow.md	Introduced new workflow directory with skill documentation, manifest defining type: skill, and updated workflow configuration. Changed path resolution from installed_path-based references to relative paths (./template.md, ./brain-methods.csv)
Legacy Workflow Cleanup src/core/workflows/brainstorming/bmad-skill-manifest.yaml	Removed three metadata fields: canonicalId, type, and description

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• refactor: convert document-project workflow.yaml to workflow.md (step 9) #1863 — Updates workflow file path references in analyst.agent.yaml for workflow reorganization
• refactor(skills): add SKILL.md entrypoint to skill directories #1868 — Adds SKILL.md skill entrypoints and adjusts workflow/manifest references for skill configuration
• fix(bmm): resolve dead references and syntax errors in agents and workflows #1164 — Modifies agent workflow references in analyst.agent.yaml to point to renamed workflow paths

Suggested reviewers

• bmadcode

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: converting the brainstorming workflow into a native skill format with a new name.
Description check	✅ Passed	The description clearly relates to the changeset, detailing the workflow refactoring, catalog updates, and agent configuration changes with verification steps.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

📝 Coding Plan for PR comments

• Generate coding plan

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (2)

src/core/workflows/bmad-brainstorming/workflow.md (2)

50-51: context_file is defined in both frontmatter and Paths section.

Line 4 defines context_file: '' in frontmatter, and line 50 redefines it in the Paths section. This redundancy could cause confusion about which takes precedence. Consider removing one to establish a single source of truth.

Additionally, advancedElicitationTask on line 51 uses an absolute {project-root}/_bmad/... path while template_path and brain_techniques_path now use relative ./ paths. This inconsistency is worth noting — should advancedElicitationTask also be relativized if the goal is to move toward relative path resolution?

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/core/workflows/bmad-brainstorming/workflow.md` around lines 50 - 51,
Remove the duplicate context_file declaration by keeping a single source of
truth (either the frontmatter `context_file` or the Paths section
`context_file`) and delete the other; update any references to use that single
field. Also make the `advancedElicitationTask` path consistent with the other
relative paths by changing
`{project-root}/_bmad/core/workflows/advanced-elicitation/workflow.md` to a
relative form (e.g., `./_bmad/core/workflows/advanced-elicitation/workflow.md`)
so it matches `template_path` and `brain_techniques_path` conventions; ensure
`advancedElicitationTask`, `template_path`, and `brain_techniques_path` all
resolve the same way.

---

45-46: Inconsistent path notation with step reference on line 57.

Lines 45-46 use ./ prefix for relative paths (./template.md, ./brain-methods.csv), but line 57 references steps/step-01-session-setup.md without the ./ prefix. While both may resolve correctly, the inconsistency creates ambiguity about the intended path resolution semantics.

♻️ Suggested normalization

Either use ./ consistently for all relative paths:

-Read fully and follow: `steps/step-01-session-setup.md` to begin the workflow.
+Read fully and follow: `./steps/step-01-session-setup.md` to begin the workflow.

Or remove ./ from lines 45-46 to match the step reference style:

-- `template_path` = `./template.md`
-- `brain_techniques_path` = `./brain-methods.csv`
+- `template_path` = `template.md`
+- `brain_techniques_path` = `brain-methods.csv`

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/core/workflows/bmad-brainstorming/workflow.md` around lines 45 - 46,
There is inconsistent relative-path notation between the variables template_path
and brain_techniques_path and the step reference; normalize them so all relative
paths use the same style. Edit the occurrences of template_path and
brain_techniques_path (and the step reference "steps/step-01-session-setup.md")
to either all include the "./" prefix (e.g., "./template.md",
"./brain-methods.csv", "./steps/step-01-session-setup.md") or remove "./" from
the first two to match the step reference; update whichever style you choose
consistently across the file.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/core/workflows/bmad-brainstorming/workflow.md`:
- Around line 50-51: Remove the duplicate context_file declaration by keeping a
single source of truth (either the frontmatter `context_file` or the Paths
section `context_file`) and delete the other; update any references to use that
single field. Also make the `advancedElicitationTask` path consistent with the
other relative paths by changing
`{project-root}/_bmad/core/workflows/advanced-elicitation/workflow.md` to a
relative form (e.g., `./_bmad/core/workflows/advanced-elicitation/workflow.md`)
so it matches `template_path` and `brain_techniques_path` conventions; ensure
`advancedElicitationTask`, `template_path`, and `brain_techniques_path` all
resolve the same way.
- Around line 45-46: There is inconsistent relative-path notation between the
variables template_path and brain_techniques_path and the step reference;
normalize them so all relative paths use the same style. Edit the occurrences of
template_path and brain_techniques_path (and the step reference
"steps/step-01-session-setup.md") to either all include the "./" prefix (e.g.,
"./template.md", "./brain-methods.csv", "./steps/step-01-session-setup.md") or
remove "./" from the first two to match the step reference; update whichever
style you choose consistently across the file.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b23e7fc2-9913-4575-9ee0-28f4b628e28d

📥 Commits

Reviewing files that changed from the base of the PR and between 861716f and 5dbf9e4.

⛔ Files ignored due to path filters (3)

• src/bmm/module-help.csv is excluded by !**/*.csv
• src/core/module-help.csv is excluded by !**/*.csv
• src/core/workflows/bmad-brainstorming/brain-methods.csv is excluded by !**/*.csv

📒 Files selected for processing (14)

• src/bmm/agents/analyst.agent.yaml
• src/core/workflows/bmad-brainstorming/SKILL.md
• src/core/workflows/bmad-brainstorming/bmad-skill-manifest.yaml
• src/core/workflows/bmad-brainstorming/steps/step-01-session-setup.md
• src/core/workflows/bmad-brainstorming/steps/step-01b-continue.md
• src/core/workflows/bmad-brainstorming/steps/step-02a-user-selected.md
• src/core/workflows/bmad-brainstorming/steps/step-02b-ai-recommended.md
• src/core/workflows/bmad-brainstorming/steps/step-02c-random-selection.md
• src/core/workflows/bmad-brainstorming/steps/step-02d-progressive-flow.md
• src/core/workflows/bmad-brainstorming/steps/step-03-technique-execution.md
• src/core/workflows/bmad-brainstorming/steps/step-04-idea-organization.md
• src/core/workflows/bmad-brainstorming/template.md
• src/core/workflows/bmad-brainstorming/workflow.md
• src/core/workflows/brainstorming/bmad-skill-manifest.yaml

💤 Files with no reviewable changes (1)

• src/core/workflows/brainstorming/bmad-skill-manifest.yaml