Skip to content

Convert qa-generate-e2e-tests workflow to native skill packaging#1951

Merged
alexeyv merged 2 commits intomainfrom
convert-qa-generate-e2e-tests-skill
Mar 14, 2026
Merged

Convert qa-generate-e2e-tests workflow to native skill packaging#1951
alexeyv merged 2 commits intomainfrom
convert-qa-generate-e2e-tests-skill

Conversation

@alexeyv
Copy link
Copy Markdown
Collaborator

@alexeyv alexeyv commented Mar 12, 2026

Summary

  • mechanically converted qa-generate-e2e-tests into native skill packaging under src/bmm/workflows/bmad-qa-generate-e2e-tests/
  • switched manifest to type: skill and added SKILL.md with matching frontmatter
  • updated dependent references in src/bmm/module-help.csv and src/bmm/agents/qa.agent.yaml

Validation

  • npm test
  • before/after equivalence checks on workflow execution section and checklist content (2 repeat runs; byte-identical hashes)
  • installer smoke run against harness directory: node tools/cli/bmad-cli.js install --directory /Users/alex/src/bmad --modules bmm --tools claude-code --yes

@augmentcode
Copy link
Copy Markdown

augmentcode bot commented Mar 12, 2026

🤖 Augment PR Summary

Summary: Migrates the QA “generate e2e tests” workflow to native skill packaging by renaming it to bmad-qa-generate-e2e-tests and adding SKILL.md + a type: skill manifest.

Changes: Updates the QA agent’s menu reference and aligns workflow paths/metadata with the new skill directory name.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@@ -1,5 +1,4 @@
---
name: qa-generate-e2e-tests
name: bmad-qa-generate-e2e-tests
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the YAML frontmatter opening delimiter (---) was removed but the closing --- remains, so tooling that discovers/parses workflows via ^---\n...\n--- will skip this file and metadata won’t be read. If this file is still meant to be a workflow entry, consider restoring valid frontmatter (or removing the dangling delimiter + raw name:/description: lines if the intent is to make this plain markdown). (Guideline: workflow_name_required)

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

alexeyv and others added 2 commits March 14, 2026 12:44
…-e2e-tests

Remove name/description from workflow.md (belongs in SKILL.md).
Normalize installed_path to relative. Update QA agent exec to skill URI.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@alexeyv alexeyv force-pushed the convert-qa-generate-e2e-tests-skill branch from 54cdfc4 to 935e3d1 Compare March 14, 2026 19:36
@alexeyv alexeyv merged commit a62e7a3 into main Mar 14, 2026
5 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 14, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

Converting the QA workflow into a native skill package by adding skill metadata files (SKILL.md and skill manifest), updating workflow path resolution to relative paths, switching the agent menu trigger from a file-path reference to a skill-based exec, and removing old workflow manifest declarations.

Changes

Cohort / File(s) Summary
Agent Configuration
src/bmm/agents/qa.agent.yaml
Updated menu trigger exec from a relative workflow.md path to skill-based reference skill:bmad-qa-generate-e2e-tests.
New Skill Package Files
src/bmm/workflows/bmad-qa-generate-e2e-tests/SKILL.md, src/bmm/workflows/bmad-qa-generate-e2e-tests/bmad-skill-manifest.yaml
Added skill metadata files: SKILL.md with frontmatter defining the skill name and description, and bmad-skill-manifest.yaml declaring type: skill.
Workflow Path Resolution
src/bmm/workflows/bmad-qa-generate-e2e-tests/workflow.md
Updated path references to use relative paths: installed_path changed to "." and checklist reference updated from project-root format to "./checklist.md".
Old Workflow Manifest Cleanup
src/bmm/workflows/qa-generate-e2e-tests/bmad-skill-manifest.yaml
Removed workflow manifest entries including canonicalId, type, and description fields from the old workflow package.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • bmadcode
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: converting a workflow to native skill packaging, which is the primary objective reflected in the file changes.
Description check ✅ Passed The description is directly related to the changeset, providing clear details about the mechanical conversion, manifest changes, and validation performed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch convert-qa-generate-e2e-tests-skill
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@alexeyv alexeyv deleted the convert-qa-generate-e2e-tests-skill branch March 15, 2026 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant