Convert correct-course workflow to native skill packaging#1942
Conversation
🤖 Augment PR SummarySummary: Migrates the existing “correct-course” workflow into a native skill package ( 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
📝 WalkthroughWalkthroughThis PR reorganizes the "correct-course" workflow by renaming it to "bmad-correct-course" and relocating it to a new directory structure. Agent YAML files are updated to reference the new workflow path, and workflow metadata, manifests, and documentation files are added or migrated to the new location. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can suggest fixes for GitHub Check annotations.Configure the |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/bmm/workflows/4-implementation/bmad-correct-course/workflow.md`:
- Around line 34-35: The installed_path variable is set to a relative path
(installed_path) which breaks the established convention used by other
workflows; update the definition of installed_path in workflow.md to the
absolute project path used elsewhere (for example set installed_path to
{project-root}/_bmad/bmm/workflows/4-implementation/bmad-correct-course) and
ensure checklist continues to reference it as checklist =
{installed_path}/checklist.md so the workflow matches sprint-planning and other
workflows.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 74e42df6-5d7d-41ed-b7b6-b205a611000c
⛔ Files ignored due to path filters (1)
src/bmm/module-help.csvis excluded by!**/*.csv
📒 Files selected for processing (7)
src/bmm/agents/pm.agent.yamlsrc/bmm/agents/sm.agent.yamlsrc/bmm/workflows/4-implementation/bmad-correct-course/SKILL.mdsrc/bmm/workflows/4-implementation/bmad-correct-course/bmad-skill-manifest.yamlsrc/bmm/workflows/4-implementation/bmad-correct-course/checklist.mdsrc/bmm/workflows/4-implementation/bmad-correct-course/workflow.mdsrc/bmm/workflows/4-implementation/correct-course/bmad-skill-manifest.yaml
💤 Files with no reviewable changes (1)
- src/bmm/workflows/4-implementation/correct-course/bmad-skill-manifest.yaml
| - `installed_path` = `.` | ||
| - `checklist` = `{installed_path}/checklist.md` |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check how other workflows define installed_path
echo "=== installed_path patterns in workflow.md files ==="
rg -n "installed_path.*=" --type=md src/bmm/workflows/ -A0 | head -30Repository: bmad-code-org/BMAD-METHOD
Length of output: 2296
🏁 Script executed:
ls -la src/bmm/workflows/4-implementation/bmad-correct-course/Repository: bmad-code-org/BMAD-METHOD
Length of output: 441
🏁 Script executed:
# Check if checklist.md exists
find src/bmm/workflows/4-implementation/bmad-correct-course/ -name "checklist.md" -type fRepository: bmad-code-org/BMAD-METHOD
Length of output: 136
🏁 Script executed:
# Check the full workflow file to see context around line 34-35
cat -n src/bmm/workflows/4-implementation/bmad-correct-course/workflow.md | sed -n '30,40p'Repository: bmad-code-org/BMAD-METHOD
Length of output: 545
🏁 Script executed:
# Compare with sprint-planning workflow to see the pattern
cat -n src/bmm/workflows/4-implementation/sprint-planning/workflow.md | sed -n '27,35p'Repository: bmad-code-org/BMAD-METHOD
Length of output: 514
🏁 Script executed:
# Search for any comments or documentation about this change
rg -B5 -A5 "installed_path.*\." src/bmm/workflows/4-implementation/bmad-correct-course/Repository: bmad-code-org/BMAD-METHOD
Length of output: 1329
🏁 Script executed:
cat src/bmm/workflows/4-implementation/bmad-correct-course/SKILL.mdRepository: bmad-code-org/BMAD-METHOD
Length of output: 292
🏁 Script executed:
# Check how this workflow's paths are referenced in steps
grep -n "checklist\|installed_path" src/bmm/workflows/4-implementation/bmad-correct-course/workflow.md | head -20Repository: bmad-code-org/BMAD-METHOD
Length of output: 758
🏁 Script executed:
# Compare with sprint-planning to see if there's a difference in how they reference paths
grep -n "checklist\|installed_path" src/bmm/workflows/4-implementation/sprint-planning/workflow.md | head -20Repository: bmad-code-org/BMAD-METHOD
Length of output: 278
🏁 Script executed:
# Search for any documentation about path resolution in the codebase
rg "relative path\|installed_path.*resolution" --type=md -B2 -A2 | head -50Repository: bmad-code-org/BMAD-METHOD
Length of output: 51
🏁 Script executed:
# Check if there are any other path references that might be affected
grep -n "\{installed_path\}\|{checklist}" src/bmm/workflows/4-implementation/bmad-correct-course/workflow.mdRepository: bmad-code-org/BMAD-METHOD
Length of output: 206
🏁 Script executed:
# Check if sprint-planning uses installed_path in similar ways
grep -n "\{installed_path\}\|{template}\|{checklist}" src/bmm/workflows/4-implementation/sprint-planning/workflow.md | head -15Repository: bmad-code-org/BMAD-METHOD
Length of output: 184
Use absolute path for installed_path to match the established convention.
Every other workflow in the suite (15+ workflows) defines installed_path as an absolute path: {project-root}/_bmad/bmm/workflows/.... This workflow uses . instead, creating an unnecessary inconsistency. While the relative path works within skill path resolution semantics, the deviation makes the codebase harder to maintain and understand. Change line 34 to match the pattern used by sprint-planning and other workflows:
- `installed_path` = `{project-root}/_bmad/bmm/workflows/4-implementation/bmad-correct-course`
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/bmm/workflows/4-implementation/bmad-correct-course/workflow.md` around
lines 34 - 35, The installed_path variable is set to a relative path
(installed_path) which breaks the established convention used by other
workflows; update the definition of installed_path in workflow.md to the
absolute project path used elsewhere (for example set installed_path to
{project-root}/_bmad/bmm/workflows/4-implementation/bmad-correct-course) and
ensure checklist continues to reference it as checklist =
{installed_path}/checklist.md so the workflow matches sprint-planning and other
workflows.
alexeyv
force-pushed
the
convert-correct-course-skill
branch
from
29eea11 to
cc7e839
Compare
Remove installed_path, checklist, and project_context variables that just indirected single-use hardcoded paths. Use bare values inline. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 participant
Summary
src/bmm/workflows/4-implementation/correct-courseinto native skill directorysrc/bmm/workflows/4-implementation/bmad-correct-coursetype: skilland addSKILL.mdmodule-help.csv,pm.agent.yaml, andsm.agent.yamlValidation
node tools/cli/bmad-cli.js install --directory /Users/alex/src/bmad --modules bmm --tools claude-code --yes/Users/alex/src/bmad/.claude/skills/bmad-correct-course/_bmad/_config/skill-manifest.csv; absent from_bmad/_config/workflow-manifest.csvworkflow.mdandchecklist.mdnpm test