Skip to content

fix: correct relative path to validation workflow in step-e-04-complete#1498

Merged
bmadcode merged 2 commits intobmad-code-org:mainfrom
arcaven:fix/step-e04-complete-relative-path
Feb 1, 2026
Merged

fix: correct relative path to validation workflow in step-e-04-complete#1498
bmadcode merged 2 commits intobmad-code-org:mainfrom
arcaven:fix/step-e04-complete-relative-path

Conversation

@arcaven
Copy link
Copy Markdown
Contributor

@arcaven arcaven commented Jan 31, 2026

Summary

The validationWorkflow reference in step-e-04-complete.md uses ./steps-v/step-v-01-discovery.md but the steps-v/ directory is a sibling of the steps-e/ directory, not inside it. The correct relative path from steps-e/ is ../steps-v/step-v-01-discovery.md.

File: src/bmm/workflows/2-plan-workflows/create-prd/steps-e/step-e-04-complete.md (line 7)

- validationWorkflow: './steps-v/step-v-01-discovery.md'
+ validationWorkflow: '../steps-v/step-v-01-discovery.md'

Directory structure:

create-prd/
├── steps-e/
│   └── step-e-04-complete.md    ← referencing file (./steps-v/ is wrong, ../steps-v/ is correct)
├── steps-v/
│   └── step-v-01-discovery.md   ← target file
└── ...

Fixes #1496

🔍 This broken reference was detected by the cross-file reference validator proposed in #1494. With that validator in CI, this class of bug would be caught automatically at PR time.

Test plan

  • npm test passes (all linting, schema validation, formatting checks)
  • Verified ../steps-v/step-v-01-discovery.md resolves to the correct file

The validationWorkflow reference uses ./steps-v/step-v-01-discovery.md
but steps-v/ is a sibling of steps-e/, not a child. Corrected to
../steps-v/step-v-01-discovery.md.

Fixes #1496
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 31, 2026

📝 Walkthrough

Walkthrough

A relative path reference in a markdown documentation file is corrected. The path to a sibling directory is updated from an incorrect relative reference using ./" to the correct parent directory traversal syntax using ../`.

Changes

Cohort / File(s) Summary
Path Reference Fix
src/bmm/workflows/2-plan-workflows/create-prd/steps-e/step-e-04-complete.md
Updated relative path reference from ./steps-v/step-v-01-discovery.md to ../steps-v/step-v-01-discovery.md to correctly reference a sibling directory instead of a non-existent subdirectory.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • alexeyv
  • muratkeremozcan
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: correcting a relative path to the validation workflow in step-e-04-complete.
Description check ✅ Passed The description is thorough and directly related to the changeset, explaining the path correction with directory structure and test verification.
Linked Issues check ✅ Passed The PR completely addresses the requirements from issue #1496: it changes the relative path from './steps-v/step-v-01-discovery.md' to '../steps-v/step-v-01-discovery.md' as specified.
Out of Scope Changes check ✅ Passed All changes are directly scoped to fixing the broken relative path in step-e-04-complete.md as required by issue #1496; no unrelated modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bmadcode bmadcode merged commit 7afe018 into bmad-code-org:main Feb 1, 2026
5 checks passed
bmadcode pushed a commit that referenced this pull request Feb 1, 2026
### 🎁 Features
* Add generate-project-context workflow
* Shard market research customer analysis

### 🐛 Bug Fixes
* Fix npm install peer dependency issues (PR #1476)
* Fix leaked source paths in PRD validation report (#1481)
* Fix orphaned market research customer analysis (#1486)
* Fix duplicate 2-letter brainstorming code (BS → BSP)
* Fix tech writer sidecar functionality (#1487)
* Fix relative paths in workflow steps (#1497, #1498)
* Fix party-mode workflow file extension (#1499)
* Fix generated slash commands (#1501)
* Fix agent scan and help CSV files
* Fix HELP_STEP placeholder replacement (#1437)

### 📚 Documentation
* Add exact slash commands to Getting Started guide (#1505)
* Remove .claude/commands from version control (#1506)

### 🔧 Maintenance
* Update Starlight to 0.37.5
* Add GitHub issue templates
@arcaven arcaven deleted the fix/step-e04-complete-relative-path branch February 5, 2026 22:05
dickymoore pushed a commit to dickymoore/BMAD-METHOD that referenced this pull request Feb 6, 2026
…te (bmad-code-org#1498)

The validationWorkflow reference uses ./steps-v/step-v-01-discovery.md
but steps-v/ is a sibling of steps-e/, not a child. Corrected to
../steps-v/step-v-01-discovery.md.

Fixes bmad-code-org#1496

Co-authored-by: Brian <bmadcode@gmail.com>
dickymoore pushed a commit to dickymoore/BMAD-METHOD that referenced this pull request Feb 6, 2026
### 🎁 Features
* Add generate-project-context workflow
* Shard market research customer analysis

### 🐛 Bug Fixes
* Fix npm install peer dependency issues (PR bmad-code-org#1476)
* Fix leaked source paths in PRD validation report (bmad-code-org#1481)
* Fix orphaned market research customer analysis (bmad-code-org#1486)
* Fix duplicate 2-letter brainstorming code (BS → BSP)
* Fix tech writer sidecar functionality (bmad-code-org#1487)
* Fix relative paths in workflow steps (bmad-code-org#1497, bmad-code-org#1498)
* Fix party-mode workflow file extension (bmad-code-org#1499)
* Fix generated slash commands (bmad-code-org#1501)
* Fix agent scan and help CSV files
* Fix HELP_STEP placeholder replacement (bmad-code-org#1437)

### 📚 Documentation
* Add exact slash commands to Getting Started guide (bmad-code-org#1505)
* Remove .claude/commands from version control (bmad-code-org#1506)

### 🔧 Maintenance
* Update Starlight to 0.37.5
* Add GitHub issue templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: broken relative path in create-prd step-e-04-complete.md

2 participants