Skip to content

fix(workflow): leaked source paths in PRD validation report#1481

Merged
bmadcode merged 2 commits intobmad-code-org:mainfrom
arcaven:fix/validation-report-leaked-source-paths
Feb 1, 2026
Merged

fix(workflow): leaked source paths in PRD validation report#1481
bmadcode merged 2 commits intobmad-code-org:mainfrom
arcaven:fix/validation-report-leaked-source-paths

Conversation

@arcaven
Copy link
Copy Markdown
Contributor

@arcaven arcaven commented Jan 31, 2026

Summary

Replaces two /src/core/ source tree paths with the {project-root}/_bmad/core/ convention in validation-report-prd-workflow.md (lines 293-294).

Context

This is the remaining half of the fix for #1435, which reported both a malformed XML syntax issue and a hardcoded developer path. The issue was closed with "will fix with .4 release" — the XML syntax and the brianmadison path on line 11 were fixed, but these two /src/core/ references were missed:

- - ✅ Party-mode workflow: Exists at `/src/core/workflows/party-mode/workflow.md`
- - ✅ Advanced-elicitation task: Exists at `/src/core/workflows/advanced-elicitation/workflow.xml`
+ - ✅ Party-mode workflow: Exists at `{project-root}/_bmad/core/workflows/party-mode/workflow.md`
+ - ✅ Advanced-elicitation task: Exists at `{project-root}/_bmad/core/workflows/advanced-elicitation/workflow.xml`

When the installer copies this file to consumer installations, the /src/core/ paths don't match the installed _bmad/core/ layout. The {project-root}/_bmad/core/ convention is consistent with how all other Beta.4 files reference cross-module paths.

Fixes #1480

Test plan

  • Verified no other files in src/bmm/ reference /src/core/ (only this file had the issue)
  • Confirmed {project-root}/_bmad/core/ is the convention used by party-mode workflow, brainstorming workflow, and excalidraw resources

Replace /src/core/ paths with {project-root}/_bmad/core/ convention
in validation-report-prd-workflow.md lines 293-294.

These paths reference party-mode and advanced-elicitation workflows
using the source tree layout (/src/core/) instead of the installed
layout ({project-root}/_bmad/core/) that Beta.4 standardized
across all other files.

This is the remaining half of the fix for #1435, which was closed
as "will fix with .4 release" but only the brianmadison path on
line 11 and the XML syntax issue were addressed. The /src/core/
paths on lines 293-294 were missed.

Fixes #1480
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 31, 2026

📝 Walkthrough

Walkthrough

This PR fixes absolute developer machine paths that were inadvertently committed to the validation report markdown file, normalizing them to use the {project-root}/_bmad/... convention standardized in Beta.4.

Changes

Cohort / File(s) Summary
Path Normalization
src/bmm/workflows/2-plan-workflows/create-prd/validation-report-prd-workflow.md
Updated two absolute file path references to use {project-root} relative paths: workflow validation path and references to party-mode and advanced-elicitation workflows.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • PR #1437: Modifies the same file with related path normalization changes to align with Beta.4 conventions.

Suggested reviewers

  • bmadcode
  • alexeyv
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description provides clear context about the change, references issue #1435 and #1480, explains the problem, provides the diff, and documents the test plan comprehensively.
Linked Issues check ✅ Passed The PR fully addresses issue #1480 by replacing the two leaked /src/core/ paths with the standardized {project-root}/_bmad/core/ convention as required.
Out of Scope Changes check ✅ Passed All changes are in-scope: the PR modifies only the two path references in validation-report-prd-workflow.md that were identified in issue #1480, with no extraneous changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title 'fix(workflow): leaked source paths in PRD validation report' accurately and specifically identifies the main change: fixing hardcoded source paths in a workflow configuration file.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@arcaven arcaven changed the title Fix leaked source paths in PRD validation report fix: leaked source paths in PRD validation report Jan 31, 2026
@arcaven arcaven changed the title fix: leaked source paths in PRD validation report fix(workflow): leaked source paths in PRD validation report Jan 31, 2026
Copy link
Copy Markdown
Collaborator

@alexeyv alexeyv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@bmadcode bmadcode merged commit 04e3dc8 into bmad-code-org:main Feb 1, 2026
5 checks passed
@bmadcode
Copy link
Copy Markdown
Collaborator

bmadcode commented Feb 1, 2026

good catch, thanks @arcaven

bmadcode pushed a commit that referenced this pull request Feb 1, 2026
### 🎁 Features
* Add generate-project-context workflow
* Shard market research customer analysis

### 🐛 Bug Fixes
* Fix npm install peer dependency issues (PR #1476)
* Fix leaked source paths in PRD validation report (#1481)
* Fix orphaned market research customer analysis (#1486)
* Fix duplicate 2-letter brainstorming code (BS → BSP)
* Fix tech writer sidecar functionality (#1487)
* Fix relative paths in workflow steps (#1497, #1498)
* Fix party-mode workflow file extension (#1499)
* Fix generated slash commands (#1501)
* Fix agent scan and help CSV files
* Fix HELP_STEP placeholder replacement (#1437)

### 📚 Documentation
* Add exact slash commands to Getting Started guide (#1505)
* Remove .claude/commands from version control (#1506)

### 🔧 Maintenance
* Update Starlight to 0.37.5
* Add GitHub issue templates
dickymoore pushed a commit to dickymoore/BMAD-METHOD that referenced this pull request Feb 6, 2026
Replace /src/core/ paths with {project-root}/_bmad/core/ convention
in validation-report-prd-workflow.md lines 293-294.

These paths reference party-mode and advanced-elicitation workflows
using the source tree layout (/src/core/) instead of the installed
layout ({project-root}/_bmad/core/) that Beta.4 standardized
across all other files.

This is the remaining half of the fix for bmad-code-org#1435, which was closed
as "will fix with .4 release" but only the brianmadison path on
line 11 and the XML syntax issue were addressed. The /src/core/
paths on lines 293-294 were missed.

Fixes bmad-code-org#1480
dickymoore pushed a commit to dickymoore/BMAD-METHOD that referenced this pull request Feb 6, 2026
### 🎁 Features
* Add generate-project-context workflow
* Shard market research customer analysis

### 🐛 Bug Fixes
* Fix npm install peer dependency issues (PR bmad-code-org#1476)
* Fix leaked source paths in PRD validation report (bmad-code-org#1481)
* Fix orphaned market research customer analysis (bmad-code-org#1486)
* Fix duplicate 2-letter brainstorming code (BS → BSP)
* Fix tech writer sidecar functionality (bmad-code-org#1487)
* Fix relative paths in workflow steps (bmad-code-org#1497, bmad-code-org#1498)
* Fix party-mode workflow file extension (bmad-code-org#1499)
* Fix generated slash commands (bmad-code-org#1501)
* Fix agent scan and help CSV files
* Fix HELP_STEP placeholder replacement (bmad-code-org#1437)

### 📚 Documentation
* Add exact slash commands to Getting Started guide (bmad-code-org#1505)
* Remove .claude/commands from version control (bmad-code-org#1506)

### 🔧 Maintenance
* Update Starlight to 0.37.5
* Add GitHub issue templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Beta.4 installer leaks dev machine path into validation-report-prd-workflow.md

3 participants