Skip to content

Overhaul workbox tabs and font improvements #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 20 commits into
base: main2.0
Choose a base branch
from
Open

Overhaul workbox tabs and font improvements #40

wants to merge 20 commits into from

Conversation

@macevhicz
Copy link
Contributor

@macevhicz macevhicz commented Oct 22, 2025

Checklist

  • I have read the CONTRIBUTING.md document
  • I formatted my changes with black
  • I linted my changes with flake8
  • I have added documentation regarding my changes where necessary
  • Any pre-existing tests continue to pass
  • Additional tests were made covering my changes

Types of Changes

  • Bugfix (change that fixes an issue)
  • New Feature (change that adds functionality)
  • Documentation Update (if none of the other choices apply)

Proposed Changes

Overhaul workbox tabs

  • Supporting linking files
  • Support backing up workbox files, with ability to scroll forward and
    backward thru previous versions. Only workboxes / prefs with changes
    are saved
  • Colorize tabs indicating state (with toolTips)
  • Support auto-sync between multiple instances of PrEditor in same core
  • Support updating prefs args / values based on json file
  • Enforce unique tab names

Fonts

  • Support resizing gui font
  • Support dialogs opening with same font as PrEditor

@macevhicz macevhicz marked this pull request as draft October 22, 2025 01:56
@macevhicz macevhicz force-pushed the markm/general_updates5 branch 4 times, most recently from be49d6f to 5d8c2f2 Compare October 23, 2025 00:28
@MHendricks
Copy link
Member

MHendricks commented Oct 25, 2025

Note: This pull request will migrate prefs to a new format that is not backwards compatible with old prefs. Moving forward to new prefs just works but if you wanted to revert to an older version of PrEditor you can loose new code changes. Do we want to do anything special with when this code is released? Major version upgrade or skip a few minor versions, something else?

@macevhicz @tbttfox

MHendricks
MHendricks reviewed Oct 25, 2025
View reviewed changes
Copy link
Member

@MHendricks MHendricks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated: I've finished this pass of review.

I haven't finished looking at all of this. I have these files remaining to look at.

  • preditor/gui/workbox_mixin.py
  • preditor/gui/workboxwidget.py
  • preditor/prefs.py

@macevhicz macevhicz force-pushed the markm/general_updates5 branch from 5d8c2f2 to 8781a28 Compare October 27, 2025 19:09
MHendricks
MHendricks reviewed Oct 28, 2025
View reviewed changes
@macevhicz macevhicz force-pushed the markm/general_updates5 branch 5 times, most recently from fed598b to f394369 Compare October 29, 2025 18:14
@macevhicz macevhicz force-pushed the markm/general_updates5 branch 4 times, most recently from 1a5d933 to 94a4157 Compare November 4, 2025 03:36
@macevhicz
Overhaul workbox tabs
c8af239 
- Supporting linking files
- Support backing up workbox files, with ability to scroll forward and
  backward thru previous versions. Only workboxes / prefs with changes
  are saved
- Colorize tabs indicating state (with toolTips)
- Support auto-sync between multiple instances of PrEditor in same core
- Support updating prefs args / values based on json file
- Enforce unique tab names
@macevhicz macevhicz force-pushed the markm/general_updates5 branch 2 times, most recently from 55ce0b8 to 4ac7f8e Compare November 5, 2025 01:02
@MHendricks MHendricks changed the base branch from main to main2.0 November 7, 2025 20:02
@MHendricks
Copy link
Member

MHendricks commented Nov 7, 2025

Note: This pull request will migrate prefs to a new format that is not backwards compatible with old prefs. Moving forward to new prefs just works but if you wanted to revert to an older version of PrEditor you can loose new code changes. Do we want to do anything special with when this code is released? Major version upgrade or skip a few minor versions, something else?

@macevhicz @tbttfox

I've changed the base from main to main2.0 as this is the first PR of the 2.0 release. We have at least two more PR's after this that will go into the 2.0 release. This PR is a significant change to the prefs system so we want to have a distinction between them.

@macevhicz macevhicz force-pushed the markm/general_updates5 branch 5 times, most recently from ecc5527 to 1451c1c Compare November 8, 2025 19:19
@macevhicz
Support resizing gui font
1a7d13c
@macevhicz
Generalize launching dialogs with matching font
8d0b67b
@macevhicz
Make AutoSave getter / setter
770d46a
@macevhicz
Removed unused arg and method
6274a20
@macevhicz
Refactor to support WorkboxTextEdit and overall cleaner structure
c843c39
@macevhicz
PR Notes
a5c80c1 
- Uniform font / gui font keyboard modifiers
- Remove QRegExp (deprecated, QRegularExpression not supported byQt.py)
- Identifier classes now subclass py3 enums
- update attr check name
- Add copy filename context menu item
- Better linked file comparisons by with `pathlib.Path` instances (ie
  remove `as_posix()`
- Cleanup doc strings
@macevhicz
Addressing extra notes
d7593af 
- Don't set a workboxes tab_widget, always get it dynamically
- Handle Reload messageboxes better
@macevhicz
Move Preferences to a uiWorkboxSTACK page
df3267b
@macevhicz
Optionally, show extra workbox debug info on tab toolTips.
e022366 
Better GRP & LYT names
@macevhicz
Optionally confirm before closing with Ctrl+Q
1221f13
@MHendricks MHendricks force-pushed the markm/general_updates5 branch from 6782dad to f00d627 Compare November 12, 2025 02:22
macevhicz and others added 7 commits November 11, 2025 18:23
@macevhicz
Add Recently Closed Workbox menu and add auto-cleanup
b854451
@macevhicz
Add workbox recycle bin
7b18c0c
@macevhicz
Change from coloring tabs with paintEvent to setTabTextColor
8cee182 
Running in Houdini, the tab bar draws poorly, so remove overriding
paintEvent, and instead use setTabTextColor and setTabTextToolTip. This
means updating colors must be triggered, it doesn't come for free as in
paintEvent.
@macevhicz
Ui updates
0f85c46 
- Simplify Options and Preferences layouts
- Add Prompt on Linked File Change option (you will get visual clues
    even if this is turned off)
- Better handling of deleted / renamed linked files
- Handful of other small fixes
@macevhicz
Improve tab context menu toolTips and prevent erroneously resaving file
f3c49a5
@macevhicz
Move handleMenuHovered and connect to tab context menus
77f994e
@MHendricks @macevhicz
Pin static-analysis to python 3.11
b9e6f53
@macevhicz macevhicz force-pushed the markm/general_updates5 branch from f00d627 to b9e6f53 Compare November 12, 2025 02:27
@macevhicz macevhicz marked this pull request as ready for review November 13, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MHendricks MHendricks MHendricks approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@macevhicz @MHendricks