Addressing dm notes

Author: macevhicz

preditor/gui/group_tab_widget/grouped_tab_widget.py

@@ -190,7 +190,6 @@ def showEvent(self, event):  # noqa: N802
 
     def tab_shown(self, index):
         editor = self.widget(index)
-        editor.__set_tab_widget__(self)
         if editor and editor.isVisible():
             editor.__show__()
 

preditor/gui/loggerwindow.py

@@ -385,7 +385,7 @@ def autoSaveEnabled(self):
         """Whether or not AutoSave option is set
 
         Returns:
-            bool: hether AutoSave option is checked or not
+            bool: Whether AutoSave option is checked or not
         """
         return self.uiAutoSaveSettingssACT.isChecked()
 

preditor/gui/workbox_mixin.py

@@ -23,6 +23,7 @@
     get_prefs_dir,
     get_relative_path,
 )
+from .group_tab_widget.one_tab_widget import OneTabWidget
 
 logger = logging.getLogger(__name__)
 
@@ -141,7 +142,10 @@ def __set_last_saved_text__(self, text):
             text (str): The text to define as last_saved_text
         """
         self._last_saved_text = text
-        self.__tab_widget__().tabBar().update()
+
+        tab_widget = self.__tab_widget__()
+        if tab_widget is not None:
+            tab_widget.tabBar().update()
 
     def __last_saved_text__(self):
         """Returns the last_saved_text on this workbox
@@ -176,7 +180,14 @@ def __tab_widget__(self):
         Returns:
             GroupedTabWidget: The tab widget which contains this workbox
         """
-        return self._tab_widget
+        tab_widget = None
+        parent = self.parent()
+        while parent is not None:
+            if issubclass(parent.__class__, OneTabWidget):
+                tab_widget = parent
+                break
+            parent = parent.parent()
+        return tab_widget
 
     def __set_tab_widget__(self, tab_widget):
         """Set this workbox's _tab_widget to the provided tab_widget"""
@@ -363,8 +374,11 @@ def __workbox_name__(self, workbox=None):
         group_name = None
         workbox_name = None
 
+        grouped_tab_widget = workbox.__tab_widget__()
+        if grouped_tab_widget is None:
+            return WorkboxName("", "")
+
         if workbox:
-            grouped_tab_widget = workbox.__tab_widget__()
             for group_idx in range(workboxTAB.count()):
                 # If a previous iteration determine workbox_name, bust out
                 if workbox_name:
@@ -381,20 +395,19 @@ def __workbox_name__(self, workbox=None):
                             workbox_name = cur_group_widget.tabText(workbox_idx)
                             break
         else:
-            grouped = workbox.__tab_widget__()
-            groupedTabBar = grouped.tabBar()
+            groupedTabBar = grouped_tab_widget.tabBar()
 
             idx = -1
-            for idx in range(grouped.count()):
-                if grouped.widget(idx) == workbox:
+            for idx in range(grouped_tab_widget.count()):
+                if grouped_tab_widget.widget(idx) == workbox:
                     break
             workbox_name = groupedTabBar.tabText(idx)
 
-            group = grouped.tab_widget()
-            groupTabBar = group.tabBar()
+            group_tab_widget = grouped_tab_widget.tab_widget()
+            groupTabBar = group_tab_widget.tabBar()
             idx = -1
-            for idx in range(group.count()):
-                if group.widget(idx) == grouped:
+            for idx in range(group_tab_widget.count()):
+                if group_tab_widget.widget(idx) == grouped_tab_widget:
                     break
             group_name = groupTabBar.tabText(idx)
 
@@ -564,7 +577,10 @@ def __set_workbox_title__(self, title):
             title (str): The text to put on the grouped tab's tabText.
         """
         _group_idx, editor_idx = self.__group_tab_index__()
-        self.__tab_widget__().tabBar().setTabText(editor_idx, title)
+
+        tab_widget = self.__tab_widget__()
+        if tab_widget is not None:
+            tab_widget.tabBar().setTabText(editor_idx, title)
 
     def __linked_file_changed__(self):
         """If a file was modified or deleted this method
@@ -588,12 +604,19 @@ def __linked_file_changed__(self):
                     'The file was deleted, removing document from editor',
                 )
                 group_idx, editor_idx = self.__group_tab_index__()
-                self.__tab_widget__().close_tab(editor_idx)
+
+                tab_widget = self.__tab_widget__()
+                if tab_widget is not None:
+                    tab_widget.close_tab(editor_idx)
+
                 return False
             elif choice:
                 self.__set_filename__("")
-                title = self.__tab_widget__().get_next_available_tab_name()
-                self.__set_workbox_title__(title)
+
+                tab_widget = self.__tab_widget__()
+                if tab_widget is not None:
+                    title = tab_widget.get_next_available_tab_name()
+                    self.__set_workbox_title__(title)
 
             # TODO: The file no longer exists, and the document should be marked as
             # changed.
@@ -985,7 +1008,10 @@ def __load_workbox_version_text__(self, versionType):
         self._backup_file = str(filepath)
 
         self.__set_text__(txt)
-        self.__tab_widget__().tabBar().update()
+
+        tab_widget = self.__tab_widget__()
+        if tab_widget is not None:
+            tab_widget.tabBar().update()
 
         filename = Path(filepath).name
         return filename, idx, count

preditor/gui/workboxwidget.py

@@ -251,7 +251,9 @@ def keyPressEvent(self, event):
         truncation, but no modifiers are registered when Enter is pressed (unlike
         when Return is pressed), so this combination is not detectable.
         """
-        self.__tab_widget__().tabBar().update()
+        tab_widget = self.__tab_widget__()
+        if tab_widget is not None:
+            tab_widget.tabBar().update()
 
         if self.process_shortcut(event):
             return